Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some design notes for the Rust-lite semantics #3

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

virgil-serbanuta
Copy link
Member

These notes are not meant to describe the definite version of the Rust-lite semantics, especially for the execution part, which is obviously incomplete, and whose configuration is just a sketch (although it may be a fairly good one).

However, these notes are meant to describe what I intended to do for this semantics, and the intent of this PR is to get approval for the direction in which this semantics will go.

These notes are out of sync with the current implementation of "indexing", which should have been called "preprocessing" anyway. I plan to fix that, unless I should change focus to a different semantics (e.g. Solidity-lite).

Copy link
Collaborator

@ACassimiro ACassimiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@virgil-serbanuta thank you for adding this documentation! This reflects the description of the semantics and adaptations that we're performing in order to implement Rust-lite, is it correct? I think it looks really good and for providing the directions on what has been implemented so far and the approach used for it. One thing that I think would be complimentary to this and valuable for the project README is the instructions on running the semantics, as well as a brief overview on what the commands provided in the project's Makefile do. Not sure if this is pertinent to this PR, though.

Furthermore, some minor notes on the text:

  • Line 22, typo byß;
  • Line 34, I believe 'int' is used where 'in' should be;

@virgil-serbanuta
Copy link
Member Author

[...] One thing that I think would be complimentary to this and valuable for the project README is the instructions on running the semantics, as well as a brief overview on what the commands provided in the project's Makefile do. Not sure if this is pertinent to this PR, though.

I added some instructions, please tell me if I should do more.

@virgil-serbanuta virgil-serbanuta merged commit f90b03f into main Aug 23, 2024
1 check passed
@virgil-serbanuta virgil-serbanuta deleted the design branch August 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants