Send tokens #70
Send tokens #70
Conversation
mx-semantics/main/accounts/tools.md
Outdated
| ) | ||
| | checkAccountExists(address: String) | ||
| | checkESDTBalance(account: String, token: String, value: Int) | ||
| | addToESDTBalance(account: String, token: String, delta: Int, allowNew: Bool) |
There was a problem hiding this comment.
Do we intend to have negative deltas to addToESDTBalance? If it is only intended to add amounts to the total balance, then perhaps we should have requires in the rules preventing modifications by negative values and possibly negative balances. Or perhaps change the naming from addToESDTBalance to something like modifyESDTBalanceByDelta.
There was a problem hiding this comment.
Yes, the deltas can be negative, see https://github.com/Pi-Squared-Inc/rust-demo-semantics/pull/70/files#diff-39d9f39de40db7c63b5cb4ada9dfd2b5c889ffadbae02c26a7db378356ef234cR50-R51. I copied the name from the existing mx-semantics. I renamed it, is it better now?
There was a problem hiding this comment.
It is, @virgil-serbanuta . Thank you!
Fixes #49
This PR is more complex than usual because it tries to follow the mx-semantics repository. The main problem is that MunltiversX transfers are tightly linked with contract calls, so I also had to implement some of the call functionality.