Summary fidUpdate function with 4 parameters
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariaKt
reviewed
Sep 24, 2024
There was a problem hiding this comment.
I am OK with this, with one question-comment. Should we use the short-circuiting andThenBool, orElseBool, for the requirements related to the if condition, to emulate the fact that they computed in only certain cases and a specific order? @dwightguth
mariaKt
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Since andBool, orBool behave like the short circuiting operators (per @dwightguth) , there is no need to change anything. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new summarized rules regarding program execution. The rule presented in this PR summarizes the
function fidUpdate(uint balance0, uint balance1, uint112 vidReserve0, uint112 vidReserve1) private {...}.By summarizing this function, we save 2109 steps.
(Without it, the program took 30874 steps, and after implementing it, the program took 28765 steps)