Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of getReserves function #45

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

Robertorosmaninho
Copy link
Contributor

@Robertorosmaninho Robertorosmaninho commented Sep 26, 2024

This PR adds the summarized rules regarding the body of program execution. The rule presented in this PR summarizes the body of getReserved function.

By summarizing this function, we save 826 steps.
(Without it, the program took 27872 steps, and after implementing it, the program took 27062 steps)

Copy link
Contributor

@mariaKt mariaKt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if you can include the bind with this summary.
Also, if you do that it might be a good idea to match the <current function> cell.

src/uniswap-summaries.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mariaKt mariaKt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for addressing the comments.

@Robertorosmaninho Robertorosmaninho merged commit 2b1217b into main Sep 26, 2024
1 check passed
@Robertorosmaninho Robertorosmaninho deleted the getReserves-summary branch September 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants