Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap summary continued #61

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Swap summary continued #61

merged 15 commits into from
Oct 10, 2024

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Oct 9, 2024

This PR adds the remaining rules needed to complete the summary of the function swap of uniswapV2Pair

function swap(uint amount0Out, uint amount1Out, address to) external {

, that was started here.

The summaries in this PR swap reduce the number of steps by 2471, from 18747 to 16276.

The effect of summarizing swap in total (including the three summaries from the last PR) is a reduction of 3349 steps, from 19625 to 16276.

Copy link
Contributor

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but overall LGTM

@mariaKt mariaKt merged commit 1ad2f04 into main Oct 10, 2024
1 check passed
@mariaKt mariaKt deleted the swap-summary-cont branch October 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants