-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/logging user action #23
Open
katedmc
wants to merge
8
commits into
develop
Choose a base branch
from
fix/logging_user_action
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the logging to catch all user actions. Log file is now appended to.
Added in size limit for logger now that user actions are appended to file.
danielmapar
reviewed
Jan 28, 2019
This class will be used consolidate logging code across TBB.
The GUI logger is now the TBBLogger, and all classes that use the GUI logger are included in the new logging design.
Abstract Player class, and subsequent child classes, now all use TBBLogger to help consolidate code usage.
The logger has been changed to use the TBB logger to clean up the code more. The ScenarioParser also uses the static error logger from TBBLogger to further clean up code.
TBBLogger added to SCALP and logging added to capture Scenario Selection.
As of now, on top of the original changes, this branch:
The overall functionality hasn't been changed as the main changes were to the logger instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
I extended the existing logging code to include all authoring app actions. The logging file appends user actions and has a max file size.
Why:
A previous issue asked for detailed logging. We now have more detailed information about what actions the users take.
How:
Utilized a different constructor for the FileHandler to add appending to the file, and changed the file limit from default to 1MB
Leveraged the logger from the GUI in InsertBefore and RightPanel classes to add logging.
Time:
Less than 15 minutes to read and review the code and PR.
Approximately 15 minutes to test code changes.
Added
Changed
How should this be manually tested?
Checking Max File Size:
Checking All user actions are logged: