Skip to content

Commit

Permalink
Update TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
uweseimet committed Sep 24, 2023
1 parent a419e5d commit c6faaf3
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions cpp/controllers/scsi_controller.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ class ScsiController : public AbstractController
void DataIn() override;
void DataOut() override;

// TODO Make non-virtual private as soon as SysTimer calls do not segfault anymore on a regular PC,
// e.g. by using ifdef __arm__. Currently the unit tests require this method to be public.
virtual void Execute();

private:

DeviceLogger logger;
Expand All @@ -103,6 +99,9 @@ class ScsiController : public AbstractController
void DataOutNonBlockOriented();
void Receive();

// TODO Make non-virtual as soon as SysTimer calls do not segfault anymore on a regular PC, e.g. by using ifdef __arm__.
virtual void Execute();

void ProcessCommand();
void ParseMessage();
void ProcessMessage();
Expand Down

0 comments on commit c6faaf3

Please sign in to comment.