-
-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
NetBSD compatibility: Increase daynaport minimum packet size to 128 b…
- Loading branch information
Showing
2 changed files
with
11 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
// Copyright (C) 2020 akuker | ||
// Copyright (C) 2014-2020 GIMONS | ||
// Copyright (C) 2001-2006 PI.([email protected]) | ||
// Copyright (C) 2023 Uwe Seimet | ||
// | ||
// Licensed under the BSD 3-Clause License. | ||
// See LICENSE file in the project root folder. | ||
|
@@ -212,13 +213,15 @@ int SCSIDaynaPort::Read(cdb_t cdb, vector<uint8_t>& buf, uint64_t) | |
// response->flags = e_no_more_data; | ||
// } | ||
int size = rx_packet_size; | ||
if (size < 64) { | ||
// A frame must have at least 64 bytes (see https://github.com/PiSCSI/piscsi/issues/619) | ||
// Note that this work-around breaks the checksum. As currently there are no known drivers | ||
// that care for the checksum, and the Daynaport driver for the Atari expects frames of | ||
// 64 bytes it was decided to accept the broken checksum. If a driver should pop up that | ||
// breaks because of this, the work-around has to be re-evaluated. | ||
size = 64; | ||
if (size < 128) { | ||
// A frame must have at least 64 bytes for the Atari driver, see https://github.com/PiSCSI/piscsi/issues/619, | ||
// but also works with 128 bytes. | ||
// The NetBSD driver requires at least 128 bytes, see https://github.com/PiSCSI/piscsi/issues/1098. | ||
// The Mac driver is also fine with 128 bytes. | ||
// Note that this work-around breaks the checksum. As currently there are no known drivers | ||
// that care for the checksum it was decided to accept the broken checksum. | ||
// If a driver should pop up that breaks because of this, the work-around has to be re-evaluated. | ||
size = 128; | ||
} | ||
SetInt16(buf, 0, size); | ||
SetInt32(buf, 2, tap.HasPendingPackets() ? 0x10 : 0x00); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
// Copyright (C) 2020 akuker | ||
// Copyright (C) 2014-2020 GIMONS | ||
// Copyright (C) 2001-2006 PI.([email protected]) | ||
// Copyright (C) 2023 Uwe Seimet | ||
// | ||
// Licensed under the BSD 3-Clause License. | ||
// See LICENSE file in the project root folder. | ||
|