Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sonarcloud versions #1225

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Change sonarcloud versions #1225

merged 1 commit into from
Oct 1, 2023

Conversation

akuker
Copy link
Member

@akuker akuker commented Oct 1, 2023

No description provided.

@akuker akuker changed the base branch from main to develop October 1, 2023 21:12
@akuker akuker changed the title IGNORE FOR NOW - Change sonarcloud versions Change sonarcloud versions Oct 1, 2023
@akuker akuker requested a review from uweseimet October 1, 2023 21:38
@akuker
Copy link
Member Author

akuker commented Oct 1, 2023

I believe this will fix the sonarcloud issue. This just updates to a current version of sonar cloud. (Note - I also re-generated the authentication token, but that didn't seem to fix the issue)

Note that C++ Tests/Analysis / sonarcloud (push) suceeded (which used version 5 sonarcloud), where the 'pull_request' run failed (which used version 4)

@akuker akuker merged commit 84c20c4 into develop Oct 1, 2023
12 of 14 checks passed
@akuker akuker deleted the akuker-patch-2 branch October 1, 2023 21:41
@uweseimet
Copy link
Contributor

@akuker That's strange, because for me 5.0.1.3006 did not work, I tried it some weeks ago. Note that 4.8.1.3023 was released after 5.0.1.3006 (see https://github.com/SonarSource/sonar-scanner-cli/releases). 5.0.1.3006 is probably not a good release to use.

@akuker
Copy link
Member Author

akuker commented Oct 1, 2023

Weird... I'll try a new PR to see if it still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants