Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python static analysis only in Web workflow #1281

Closed
wants to merge 1 commit into from

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Nov 1, 2023

No description provided.

Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rdmark
Copy link
Member Author

rdmark commented Nov 1, 2023

@uweseimet As far as I can tell, what happens when two Sonar analysis jobs runs on the same PR / branch, the one that finishes later will overwrite the one that finishes earlier in the Sonarcloud database. Namely, the C++ analysis will always overwrite the Python analysis, since the former takes a lot longer time.

If I'm not mistaken, this means that when the PR is later merged into develop, the develop branch report on Sonarcloud will only ever contain the analysis of the C++ code. This is not what we want, I think. I suggest we discard this PR in favor of #1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants