Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze Python dependencies with pip freeze -l #1322

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Nov 9, 2023

Use pip freeze -l to programmatically capture the python dependency map for the python packages.

@rdmark rdmark requested a review from akuker as a code owner November 9, 2023 08:01
Copy link
Contributor

@uweseimet uweseimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you have chosen the versions well ;-)

@uweseimet
Copy link
Contributor

@rdmark You have commented on changes after approval very recently, haven't you? ;-)

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rdmark
Copy link
Member Author

rdmark commented Nov 9, 2023

@uweseimet Thanks for reviewing. These versions are automatically calculated by pip freeze using the PyPI dependency tree. They are the same that pip will fetch and install presently, but freezing them protects against future changes to the state of PyPI.

I pushed a change just now with a note on this in the README, as well as the frozen dependencies for the common package (which I had overlooked before.)

@rdmark
Copy link
Member Author

rdmark commented Nov 9, 2023

You have commented on changes after approval very recently, haven't you? ;-)

@uweseimet Haha, I don't think that was me! I have full confidence in all project members to be responsible with their post-approval commits. ;)

@rdmark rdmark merged commit bd33f66 into develop Nov 9, 2023
11 of 12 checks passed
@rdmark rdmark deleted the rdmark-issue-1320 branch November 9, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants