Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow: Build unit tests in debug mode #1417

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 16, 2024

Also, only run CI jobs for pushes when merged to main or develop.

Since Uwe has resigned as active contributor, I prioritize saving on GitHub actions minutes. It is arguably more important that code from non-members get the workflow treatment to catch bugs in their code early.

Project members are now encouraged to open a PR in order to get the workflow to execute. The PR can be kept in draft state during active development.

@rdmark
Copy link
Member Author

rdmark commented Jan 17, 2024

Now I recalled why we want the pull request hooks. It’s for branches originating from forks. (I keep forgetting and making the wrong assumption.) Reverting this back to Draft status for further refinement.

Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rdmark rdmark marked this pull request as ready for review January 18, 2024 03:39
@rdmark rdmark merged commit 818addb into develop Jan 18, 2024
8 of 10 checks passed
@rdmark rdmark deleted the rdmark-issue-1414 branch January 18, 2024 04:38
@rdmark
Copy link
Member Author

rdmark commented Jan 18, 2024

Bypassing CR rule in order to unblock pipeline.

rdmark added a commit that referenced this pull request May 1, 2024
* Run CI jobs on push events only when merged to develop or main

* Build unit tests with debug flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant