Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 3d models #2

Merged
merged 50 commits into from
Oct 7, 2024
Merged

Merge 3d models #2

merged 50 commits into from
Oct 7, 2024

Conversation

henrygerardmoore
Copy link
Collaborator

@henrygerardmoore henrygerardmoore commented Sep 13, 2024 •
edited
Loading

Must be merged after #1 and #3

Only needed minor changes to get it building, no merge conflicts. The changes were just API changes in ceres stuff that has changed since the PR was made.

Upstream PR is here

@henrygerardmoore henrygerardmoore marked this pull request as ready for review September 17, 2024 17:15
@henrygerardmoore henrygerardmoore marked this pull request as draft September 25, 2024 16:28
@henrygerardmoore henrygerardmoore marked this pull request as ready for review September 26, 2024 19:16
@henrygerardmoore henrygerardmoore mentioned this pull request Sep 27, 2024
Merged
@henrygerardmoore
Copy link
Collaborator Author

henrygerardmoore commented Sep 27, 2024 •
edited
Loading

Something is wrong with docker buildx, I think. CI failure unrelated to latest changes, passed as of 2c5ee14 so pay attention to that if CI is still not working when reviewing docker hub is down, disregard CI ATM we're so back

@henrygerardmoore henrygerardmoore mentioned this pull request Sep 27, 2024
Merged
henrygerardmoore and others added 24 commits October 3, 2024 01:22
@henrygerardmoore
add clang-tidy to pre-commit
c45e85c
@henrygerardmoore
move pre-commit to after build in CI and make clang-tidy optional
a33b717
@henrygerardmoore
default to not running clang tidy, but let the user know
81ef290
@henrygerardmoore
specify version
e31c89b
@henrygerardmoore
update first?
69af8ea
@henrygerardmoore
cd into correct wd
2d66302
@henrygerardmoore
change pip cache owner
04b5911
@henrygerardmoore
remove industrial CI
60c46d6
@henrygerardmoore
chown more stuff
10abfa4
@henrygerardmoore
try without container
9a6c4ce
@henrygerardmoore
try without checkout
66534b7
@henrygerardmoore
add container back
6b86114
@henrygerardmoore
try clang tidy outside pre-commit
8748a8f
@henrygerardmoore
run only on changed cpp/hpp files
e7ca98f
@henrygerardmoore
point to config file
2ae9f73
@henrygerardmoore
change files to last
58d3ca6
@henrygerardmoore
fix clang tidy path
5c4a5fa
@henrygerardmoore
try adding back some checks
6424c7a
@henrygerardmoore
try removing cache
445fb27
@henrygerardmoore
clang tidy fix
ad64883
@henrygerardmoore
Merge branch 'add_clang_tidy' into merge_3d_models
65fc8bf
@henrygerardmoore
remove most oft-violated checks
9d22bde
@henrygerardmoore
don't run clang tidy on main
b874508
@henrygerardmoore
Merge branch 'main' into merge_3d_models
a8f2389
@henrygerardmoore
Copy link
Collaborator Author

Clang-tidy is going to fail on this, but I'm not going through and fixing everything. That would simply take too long.

@henrygerardmoore henrygerardmoore requested review from bgill92 and removed request for bgill92 October 7, 2024 15:38
bgill92
bgill92 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@bgill92 bgill92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3d tutorials work as expected, and the code looks good 👍🏽

@henrygerardmoore henrygerardmoore merged commit 6212aeb into main Oct 7, 2024
3 of 4 checks passed
@henrygerardmoore henrygerardmoore deleted the merge_3d_models branch October 7, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgill92 bgill92 bgill92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrygerardmoore @bgill92