Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JointDiagnostic Objective #80

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix JointDiagnostic Objective #80

merged 1 commit into from
Jan 9, 2025

Conversation

marioprats
Copy link

@marioprats marioprats commented Jan 7, 2025

The waypoints used in the lab_sim config in the Joint Diagnostic Objective are very close to self-collision.
Pro-RRT has a default padding of 1cm to help with tunneling issues. That padding makes this Objective fail, since it would bring the waypoints to a self-collision.
This PR closes #10136 by manually overriding link_padding=0.0 in the Joint Diagnostic Objective.
But moving directly to the waypoints via the Teleoperate panel would have the same issue. So this PR also overrides the Teleoperate Objective and sets link_padding=0.0 there too.

resolves https://github.com/PickNikRobotics/moveit_pro/issues/10136

@marioprats marioprats requested a review from dyackzan January 7, 2025 12:24
Copy link

@dyackzan dyackzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Joint Diagnostic objective for me but teleop-ing to the wrist max/min waypoints still fails. It looks like the "Request Teleoperation" objective from the parent picknik_ur_base_config is still being used for me with the non-zero link padding...I think this is potentially because you haven't added the top level "Teleoperate" objective so it's using the inherited one that pulls in the base "Request Teleoperation" objective

@marioprats
Copy link
Author

Are you using the dev workflow or user workflow? I noticed with the dev workflow that it wasn't redefining the symlink to the lab_sim request_teleoperation.xml for some reason. I had to remove ~/.config/moveit_pro/lab_sim/ and then it worked. Wondering if there's something broken with the Objective override mechanism? I also tried adding the teleoperate.xml but still didn't work without me manually removing ~/.config/moveit_pro/lab_sim/

@marioprats
Copy link
Author

@dyackzan I tried again with a fresh docker container and it worked for me. Could you please try again and check if you still see the issue?

@marioprats marioprats requested a review from dyackzan January 9, 2025 11:57
Copy link

@dyackzan dyackzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the user workflow with 7.0.0-rc8. I saw the same issue with teleop when I just ran it, but after I pruned my docker images and rebuilt it registered your changes...seems odd those symlinks aren't updated properly without removing the docker images

@marioprats marioprats merged commit fdd75b7 into v7.0 Jan 9, 2025
4 checks passed
MikeWrock pushed a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants