Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.1 Python #360

Merged
merged 5 commits into from
Nov 29, 2024
Merged

v2.1 Python #360

merged 5 commits into from
Nov 29, 2024

Conversation

ben-w-conrad
Copy link

No description provided.

@ben-w-conrad ben-w-conrad requested a review from laves November 29, 2024 00:24
laves
laves requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be safe, you should also have the demo install this new local version, because currently the action is just installing the old version and checking that it succeeds

binding/python/__init__.py Outdated Show resolved Hide resolved
binding/python/_factory.py Outdated Show resolved Hide resolved
@ben-w-conrad ben-w-conrad marked this pull request as ready for review November 29, 2024 20:23
@ben-w-conrad ben-w-conrad requested a review from laves November 29, 2024 20:24
@laves laves merged commit 69550b2 into v2.1 Nov 29, 2024
51 checks passed
@laves laves deleted the v2.1-python branch November 29, 2024 21:27
ErisMik pushed a commit that referenced this pull request Dec 3, 2024
@ben-w-conrad @ErisMik
v2.1 Python (#360)
c4d1db5
ErisMik pushed a commit that referenced this pull request Dec 5, 2024
@ben-w-conrad @ErisMik
v2.1 Python (#360)
1621887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laves laves laves approved these changes

Assignees

@laves laves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-w-conrad @laves