Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web v0.2 update #20

Merged
merged 32 commits into from
May 8, 2024
Merged

Web v0.2 update #20

merged 32 commits into from
May 8, 2024

Conversation

albho
Copy link
Contributor

@albho albho commented Apr 22, 2024

No description provided.

@albho albho changed the base branch from main to orca-prepare-v0.2 April 22, 2024 22:07
@albho albho force-pushed the web-v0.2-update branch from 397f9f9 to 53226fa Compare April 22, 2024 22:12
@albho albho requested a review from ksyeo1010 April 22, 2024 22:19
@ksyeo1010
Copy link
Contributor

streaming demo first character throws corresponding error:

Uncaught TypeError: Cannot set properties of null (setting 'innerText')
    at HTMLInputElement.<anonymous>

@ksyeo1010
Copy link
Contributor

when you try to delete a character in the streaming text, it adds the whole word on to the stream

@ksyeo1010
Copy link
Contributor

Also can't get to play the stream correctly. It bugs out and sometimes it plays sometimes it does not. Flushing does not stream properly as well.

@ksyeo1010
Copy link
Contributor

Not sure if I understand correctly, but is the demo supposed to be playing as I type or only as I flush?

bejager
bejager reviewed Apr 29, 2024
View reviewed changes
ksyeo1010
ksyeo1010 reviewed Apr 30, 2024
View reviewed changes
@albho albho force-pushed the web-v0.2-update branch from 3b344f4 to 89f99ee Compare May 2, 2024 19:11
bejager
bejager reviewed May 3, 2024
View reviewed changes
laves
laves requested changes May 8, 2024
View reviewed changes
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions are not running - this PR should not be merged until they have succeeded

@albho albho closed this May 8, 2024
@albho albho reopened this May 8, 2024
@bejager
Copy link
Contributor

bejager commented May 8, 2024

Tests seem to be good now. Once @laves approves I'll merge it to the v0.2 branch.
Same for the android branch.

@bejager bejager merged commit e264960 into orca-prepare-v0.2 May 8, 2024
8 checks passed
@bejager bejager deleted the web-v0.2-update branch May 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejager bejager bejager left review comments

@laves laves laves approved these changes

@ksyeo1010 ksyeo1010 ksyeo1010 approved these changes

Assignees

@bejager bejager

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albho @ksyeo1010 @bejager @laves