-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web binding #4
Web binding #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go over orca.ts later
Is it easy to add a 'download' feature to the demo? |
Good job! once @ksyeo1010 and @bejager approve this, will merge it to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I played around with the demo and it works fine except when there is an exception.
E.g. when having a wrongly formatted custom pron: "A {|KH A S T OM } pron" the demo shows exception fine but it does not allow any changes to the text field anymore. One has to refresh the browser and init again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I just saw this, the only thing I am wondering is why did we choose to go with callbacks instead of just returning Int16Arrays from the function itself after waiting for the async call? If anything, I think this should be similar to Leopard's methods.
I believe this is good to merge, the one failing link is to the demo which won't exist until this is merged |
Will need to update with new
.wasm
files when ready and adjust initial wasm memory (orca.ts
).