test: add provider for test article and categories

Pierre-brtrd · Aug 1, 2023 · 24fc701 · 24fc701
1 parent eefab78
commit 24fc701
Show file tree

Hide file tree

Showing 6 changed files with 110 additions and 38 deletions.
diff --git a/src/Entity/Article.php b/src/Entity/Article.php
@@ -2,29 +2,29 @@
 
 namespace App\Entity;
 
-use ApiPlatform\Doctrine\Orm\Filter\BooleanFilter;
-use ApiPlatform\Doctrine\Orm\Filter\SearchFilter;
-use ApiPlatform\Metadata\ApiFilter;
-use ApiPlatform\Metadata\ApiProperty;
-use ApiPlatform\Metadata\ApiResource;
-use ApiPlatform\Metadata\Delete;
 use ApiPlatform\Metadata\Get;
-use ApiPlatform\Metadata\GetCollection;
+use ApiPlatform\Metadata\Put;
 use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Post;
-use ApiPlatform\Metadata\Put;
-use App\Api\Controller\Articles\ArticleCreateController;
-use App\Repository\ArticleRepository;
-use Doctrine\Common\Collections\ArrayCollection;
-use Doctrine\Common\Collections\Collection;
 use Doctrine\DBAL\Types\Types;
+use ApiPlatform\Metadata\Delete;
 use Doctrine\ORM\Mapping as ORM;
+use ApiPlatform\Metadata\ApiFilter;
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use App\Repository\ArticleRepository;
 use Gedmo\Mapping\Annotation as Gedmo;
-use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
-use Symfony\Component\Serializer\Annotation\Context;
+use ApiPlatform\Metadata\GetCollection;
+use Doctrine\Common\Collections\Collection;
+use Doctrine\Common\Collections\ArrayCollection;
+use ApiPlatform\Doctrine\Orm\Filter\SearchFilter;
+use ApiPlatform\Doctrine\Orm\Filter\BooleanFilter;
 use Symfony\Component\Serializer\Annotation\Groups;
-use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
+use Symfony\Component\Serializer\Annotation\Context;
 use Symfony\Component\Validator\Constraints as Assert;
+use App\Api\Controller\Articles\ArticleCreateController;
+use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
+use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
 
 #[ApiResource(
     operations: [
@@ -155,6 +155,12 @@ class Article
      */
     #[ORM\Column(length: 150, unique: true)]
     #[Groups(['comment:list', 'article:list', 'article:post', 'article:put'])]
+    #[Assert\Length(
+        min: 3,
+        max: 150,
+        minMessage: 'Le titre de l\'article ne peut être inférieur à {{ limit }} caractères.',
+        maxMessage: 'Le titre de l\'article ne peut être supérieur à {{ limit }} caractères.'
+    )]
     private ?string $titre = null;
 
     /**

diff --git a/src/Entity/Categorie.php b/src/Entity/Categorie.php
@@ -2,18 +2,19 @@
 
 namespace App\Entity;
 
-use ApiPlatform\Metadata\ApiResource;
-use ApiPlatform\Metadata\Delete;
 use ApiPlatform\Metadata\Get;
-use ApiPlatform\Metadata\GetCollection;
-use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Put;
+use ApiPlatform\Metadata\Post;
+use ApiPlatform\Metadata\Delete;
+use Doctrine\ORM\Mapping as ORM;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\GetCollection;
 use App\Repository\CategorieRepository;
-use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
-use Doctrine\ORM\Mapping as ORM;
-use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
+use Doctrine\Common\Collections\ArrayCollection;
 use Symfony\Component\Serializer\Annotation\Groups;
+use Symfony\Component\Validator\Constraints as Assert;
+use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
 
 #[ApiResource(
     operations: [
@@ -104,6 +105,12 @@ class Categorie
      */
     #[ORM\Column(length: 100)]
     #[Groups(['article:list', 'tags:list', 'tags:post'])]
+    #[Assert\Length(
+        min: 3,
+        max: 100,
+        minMessage: 'user.title.length.min',
+        maxMessage: 'user.title.length.max'
+    )]
     private ?string $titre = null;
 
     /**

diff --git a/tests/Entity/ArticleTest.php b/tests/Entity/ArticleTest.php
@@ -3,12 +3,12 @@
 namespace App\Tests\Entity;
 
 use App\Entity\Article;
-use App\Repository\ArticleRepository;
-use App\Repository\CategorieRepository;
 use App\Repository\UserRepository;
 use App\Tests\Utils\AssertTestTrait;
-use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
+use App\Repository\ArticleRepository;
+use App\Repository\CategorieRepository;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
 
 class ArticleTest extends KernelTestCase
 {
@@ -27,9 +27,9 @@ public function testRepositoryCount()
     {
         $articles = $this->databaseTool->loadAliceFixture(
             [
-                \dirname(__DIR__).'/Fixtures/UserTestFixtures.yaml',
-                \dirname(__DIR__).'/Fixtures/ArticleTestFixtures.yaml',
-                \dirname(__DIR__).'/Fixtures/TagTestFixtures.yaml',
+                \dirname(__DIR__) . '/Fixtures/UserTestFixtures.yaml',
+                \dirname(__DIR__) . '/Fixtures/ArticleTestFixtures.yaml',
+                \dirname(__DIR__) . '/Fixtures/TagTestFixtures.yaml',
             ]
         );
 
@@ -64,14 +64,44 @@ public function testNonUniqueTitreEntity()
         $this->assertHasErrors($article, 1);
     }
 
-    public function testMinLentgthContentEntity()
+    /**
+     * @dataProvider provideLengthTitre
+     * @return void
+     */
+    public function testLengthTitle(string $title): void
+    {
+        $article = $this->getEntity()
+            ->setTitre($title);
+
+        $this->assertHasErrors($article, 1);
+    }
+
+    private function provideLengthTitre(): array
+    {
+        return [
+            'min' => ['title' => str_repeat('a', 2)],
+            'max' => ['title' => str_repeat('a', 151)],
+        ];
+    }
+
+    /**
+     * @dataProvider provideLengthContent
+     */
+    public function testLentgthContentEntity(string $content): void
     {
         $article = $this->getEntity()
-            ->setContent('Desc');
+            ->setContent($content);
 
         $this->assertHasErrors($article, 1);
     }
 
+    private function provideLengthContent(): array
+    {
+        return [
+            'min' => ['content' => str_repeat('a', 2)]
+        ];
+    }
+
     protected function tearDown(): void
     {
         parent::tearDown();

diff --git a/tests/Entity/CategorieTest.php b/tests/Entity/CategorieTest.php
@@ -3,11 +3,11 @@
 namespace App\Tests\Entity;
 
 use App\Entity\Categorie;
+use App\Tests\Utils\AssertTestTrait;
 use App\Repository\ArticleRepository;
 use App\Repository\CategorieRepository;
-use App\Tests\Utils\AssertTestTrait;
-use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
 
 class CategorieTest extends KernelTestCase
 {
@@ -26,8 +26,8 @@ public function testRepositoryCount()
     {
         $tags = $this->databaseTool->loadAliceFixture(
             [
-                \dirname(__DIR__).'/Fixtures/ArticleTestFixtures.yaml',
-                \dirname(__DIR__).'/Fixtures/TagTestFixtures.yaml',
+                \dirname(__DIR__) . '/Fixtures/ArticleTestFixtures.yaml',
+                \dirname(__DIR__) . '/Fixtures/TagTestFixtures.yaml',
             ]
         );
 
@@ -59,6 +59,29 @@ public function testNonUniqueTitreEntity()
         $this->assertHasErrors($article, 1);
     }
 
+    /**
+     * @dataProvider provideTitleLength
+     * @return void
+     */
+    public function testTitleLength(string $title): void
+    {
+        $article = $this->getEntity()
+            ->setTitre($title);
+
+        $this->assertHasErrors($article, 1);
+    }
+
+    /**
+     * @return array
+     */
+    private function provideTitleLength(): array
+    {
+        return [
+            'min' => ['title' => str_repeat('a', 2)],
+            'max' => ['title' => str_repeat('a', 101)],
+        ];
+    }
+
     protected function tearDown(): void
     {
         parent::tearDown();

diff --git a/tests/Panther/ArticlePantherTest.php b/tests/Panther/ArticlePantherTest.php
@@ -3,8 +3,8 @@
 namespace App\Tests\Panther;
 
 use Facebook\WebDriver\WebDriverBy;
-use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
 use Symfony\Component\Panther\PantherTestCase;
+use Liip\TestFixturesBundle\Services\DatabaseToolCollection;
 
 class ArticlePantherTest extends PantherTestCase
 {
@@ -18,9 +18,9 @@ protected function setUp(): void
 
         $this->databaseTool = self::getContainer()->get(DatabaseToolCollection::class)->get();
         $this->databaseTool->loadAliceFixture([
-            \dirname(__DIR__).'/Fixtures/UserTestFixtures.yaml',
-            \dirname(__DIR__).'/Fixtures/ArticleTestFixtures.yaml',
-            \dirname(__DIR__).'/Fixtures/TagTestFixtures.yaml',
+            \dirname(__DIR__) . '/Fixtures/UserTestFixtures.yaml',
+            \dirname(__DIR__) . '/Fixtures/ArticleTestFixtures.yaml',
+            \dirname(__DIR__) . '/Fixtures/TagTestFixtures.yaml',
         ]);
     }
 

diff --git a/translations/Français/validators.fr.yaml b/translations/Français/validators.fr.yaml
@@ -6,3 +6,9 @@ form:
         not_blank: Entrez un mot de passe
         min_length: Votre mot de passe doit faire plus de {{ limit }} caractères
         no_match: Les mot de passe ne correspondent pas.
+
+tag:
+  title:
+    length:
+      min: Le titre doit contenir au moins {{ limit }} caractères
+      max: Le titre doit contenir au maximum {{ limit }} caractères