Adding coffee lake

[ibash]

@Piker-Alpha I took a pass at adding coffee lake data.
This also required upping the sanity check for number of cores :)
I'm not sure if this works, it generates ssdt.aml but I'm away from my build so I can't test it.

Previously when I tried adding the 8700k to "User Data.cfg" I was able to generate the ssdt.aml but it seemed like I wasn't reaching the max turboboost.

[Sisqo83]

Hi ibash,

thanks for implementing the Coffee lake data and checks. I gave it a try on my 8700K, but ended up with an error Unknown CPU model.
I tried your UserDefined beta as well as the more complex CoffeeLake defined branch, both same error. Also tried with changing "k" to capital "K" in config.

[Sisqo83]

Found the problem, download/sync of cfg files is from Piker's Original Source and not from the modified with Coffee Lake entries, so even having the right package with cfgs in download folder, under User/Library/ssdtPRGen still no Coffee Lake entries in cfgs. Had to hardcopy it by hand. Then script works, x86PlatformPlugin loaded. Perfect.

[ibash]

@Sisqo83 glad you got it working. The other way would be to use the zip version.
Any chance you could use intel power gadget to verify the p-states are what you expect?

Also - when I tried this I wasn't getting the turbo boost speed I was expecting, but it's possible that I was measuring it wrong. Mind giving that a shot too?

[Sisqo83]

I used zip, but didn't copy from local folder but download into User/Library/ssdtPRGen.
But this should be solved automatically as commitment approved and in original branch.

I used the AppleIntelInfo.kext and PowerGadget, everything is working as expected.

The turbo boost is fitting, 4700 with stock 8700K settings, and 5000 with BIOS optimization. Everything showing in PowerGadget and HWMonitor.
Of course you have to rebuild SSDT and manually change the cfg entry with Turbo Clock to your OC value.

Here is newest 2.9 AppleIntelInfo.kext by Piker-Alpha, had it compiled with xCode to verify P States yesterday.

AppleIntelInfo.zip

[harrison-n]

Any way to get this PR Merged.

Going to try @Sisqo83 tips to get this working in the meantime. Side note: Were you able to run prime95 blend test to make sure the overclock was stable? I noticed it was having workers fail with rounding errors in High Sierra when I tried it and was hoping this would fix it but I kind of doubt it will.

What's the difference between -turbo and -frequency?

[ibash]

@harrison-n -frequency is the base frequency I think and -turbo is what it should turbo boost to.
https://ark.intel.com/products/126684/Intel-Core-i7-8700K-Processor-12M-Cache-up-to-4_70-GHz
Processor Base Frequency vs Max Turbo Frequency

[harrison-n]

I'm getting

ssdtPRGen.sh v0.9  Copyright (c) 2011-2012 by † RevoGirl
             v6.6  Copyright (c) 2013 by † Jeroen
             v21.5 Copyright (c) 2013-2017 by Pike R. Alpha
-----------------------------------------------------------
Bugs > https://github.com/Piker-Alpha/ssdtPRGen.sh/issues <

System information: Mac OS X 10.13.1 (17B48)
Brandstring: "Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz"

Override value: (-turbo) maximum (turbo) frequency, now using: 5000 MHz!

Error: 'BridgeType' must be 0, 1, 2 or 3 ...
Aborting ...
Done.

when I run

~/ssdtPRGen.sh -turbo 5000 -target 6 -b Mac-BE088AF8C5EB4FA2 -model iMac18,3

Any Ideas?

[harrison-n]

Also doing a

~/ssdtPRGen.sh -show Coffeelake

Gives back

ssdtPRGen.sh v0.9  Copyright (c) 2011-2012 by † RevoGirl
             v6.6  Copyright (c) 2013 by † Jeroen
             v21.5 Copyright (c) 2013-2017 by Pike R. Alpha
-----------------------------------------------------------
Bugs > https://github.com/Piker-Alpha/ssdtPRGen.sh/issues <

Supported board-id / model combinations for:
--------------------------------------------

Coffee Lake
Mac-XXXXXXXXXXXXXXXX / Undefined

[harrison-n]

I was able to get it working by using -p 'i7-8700k' instead

[glasgreat]

It took me a few try's to get this working after getting unknown processor, but here is how I successfully created the ssd.aml file.

1. curl -o ~/ssdtPRGen.sh https://raw.githubusercontent.com/Piker-Alpha/ssdtPRGen.sh/Beta/ssdtPRGen.sh

2. chmod +x ~/ssdtPRGen.sh

3. sudo ~/ssdtPRGen.sh

Expect error unknown processor, but it has created the ssdtPRGen folder in ~/Library

4. Download following files Coffee Lake.cfg / Versions.cfg and ssdtPRGen.sh and save to desktop.

5. Open Data folder:
   open . ~/Library/ssdtPRGen/Data/
   and replace Coffee Lake.cfg and Versions.cfg with downloaded files on desktop.

6. Open home directory:
   open . ~/
   and replace ssdtPRGen.sh in your with the one saved on your desktop.

7. chmod +x ~/ssdtPRGen.sh

8. sudo ~/ssdtPRGen.sh

@ibash, thanks for adding the Coffee Lake data.
@Piker-Alpha, Thank you.

[ibash]

Just spent a few hours trying to get overclocking working, but not luck. Despite changing the values of base / turbo, and enabling overclocking in the bios, it seems like I could only reach 4.3ghz. I'm using an 8700k and asrock pro4, so I'd expect to be able to get much higher values.

It seems like my ssdt.aml isn't loaded when I enable overclocking in the bios...? not sure

If I turn off overclocking on my board I get up to 4.5-4.6ghz

If anyone figures out how to do it, please let me know :)

[glasgreat]

@ibash

You mention changing values of base and turbo, do you mean like this below ?

+gDesktopCoffeeLakeCPUList=(
 +#
 +# Intel 8th Generation (Coffee Lake).
 +#
 +i7-8700k,95,800,3700,**4700**,6,12

and change value to 5GHz ?
or add a second line with this ?

+gDesktopCoffeeLakeCPUList=(
 +#
 +# Intel 8th Generation (Coffee Lake).
 +#
 +i7-8700k,95,800,3700,4700,6,12
 +i7-8700k,95,800,3700, 5000,6,12  # Overclocked

[ibash]

For testing? I tried that with no luck

[glasgreat]

@ibash

Strange that you can get upto 4.6GHz without overclock and only 4.3GHz with . A long shot, but is a BIOS update available for your ASRock board and can you get higher than 4.3GHz with multi core enhancement turned on ?

[glasgreat]

@ibash

Have a look at this thread on tonymac, the original poster has 5GHz with working steps and has same board as yourself and is using this pull.

[ibash]

@glasgreat thanks for the reference, I'll check that out!

[talha-asad]

@ibash, in your Coffee Lake.cfg you have mistakenly kept the Processor "k" in small case, which is wrong and that is why some people get the unknown processor model error, because the string doesn't match with the actual processor brand string which has capital K. please fix that.

[ibash]

@talha-asad thanks for the heads up!

[volcan96]

It took me a few try's to get this working after getting unknown processor, but here is how I successfully created the ssd.aml file.

1. curl -o ~/ssdtPRGen.sh https://raw.githubusercontent.com/Piker-Alpha/ssdtPRGen.sh/Beta/ssdtPRGen.sh
2. chmod +x ~/ssdtPRGen.sh
3. sudo ~/ssdtPRGen.sh

Expect error unknown processor, but it has created the ssdtPRGen folder in ~/Library

1. Download following files Coffee Lake.cfg / Versions.cfg and ssdtPRGen.sh and save to desktop.
2. Open Data folder:
   open . ~/Library/ssdtPRGen/Data/
   and replace Coffee Lake.cfg and Versions.cfg with downloaded files on desktop.
3. Open home directory:
   open . ~/
   and replace ssdtPRGen.sh in your with the one saved on your desktop.
4. chmod +x ~/ssdtPRGen.sh
5. sudo ~/ssdtPRGen.sh

@ibash, thanks for adding the Coffee Lake data.
@Piker-Alpha, Thank you.

Probably outdated by now since I think clover setting of plugintype=1 gives ssdts. but i'd love to test this out as a reference @glasgreat can you post the correct link to version.cfg? looks like it's linked to ssdtprgen.sh . or if I'm missing something, let me know.