Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Rollup build #689

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix - Rollup build #689

merged 3 commits into from
Feb 27, 2024

Conversation

gentslava
Copy link

Rollup build config changes:

@gentslava gentslava changed the base branch from master to dev December 5, 2023 05:06
@gentslava
Copy link
Author

Hello @PiotrMachowski
I've added changes to production files. Please, review it.
It should fix Rollut build and make GHA more stable and a little faster 😊
I haven't touch the rollup.config.dev.js and it still has same error on npm start cause of rollup-plugin-serve package.

@gentslava
Copy link
Author

Hi @PiotrMachowski
You can check it and re-run GHA. I've regenerated package-lock with the Node v14.
In the prev commit I forgot to revert it after I've tried Node lts :D

@gentslava
Copy link
Author

gentslava commented Dec 7, 2023

It works again 🎉
Now you can merge it. And I'll rebase branch with translation changes in PR #687 to make it buildable in GHA.

@PiotrMachowski PiotrMachowski merged commit a79eca3 into PiotrMachowski:dev Feb 27, 2024
1 of 2 checks passed
@PiotrMachowski
Copy link
Owner

Thanks, @gentslava!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants