Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issue with escaped entities in RSS #10262

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

cfjedimaster
Copy link
Contributor

WHAT

I ran into an issue where a workflow based on my RSS feed, https://www.raymondcamden.com/feed.xml, wasn't working correctly. The escape HTML entities in the title were being stripped out. I determined it came from the trigger. While looking at feedparser's github repo, I found that it was intentional, danmactough/node-feedparser#243, and that a workaround was to check for the meta values. My fix does this and overwrites the item.title ortiginally set. I did not test this as it was small, but, it was pretty minor.

copilot:summary

copilot:poem

WHY

I think I kinda covered it above.

HOW

copilot:walkthrough

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 5:31pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 5:31pm

@dylburger dylburger added the User submitted Submitted by a user label Feb 7, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Feb 7, 2024
@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

michelle0927
michelle0927 previously approved these changes Feb 7, 2024
Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Attempt-to-fix-issue-with-escaped-entities-in-RSS-10262-3d64c3efd8e148aeafa77b300667600f

@cfjedimaster
Copy link
Contributor Author

So I made the code change to check for item, and I have a failure: " could not find app name slug in directory 'formpress'" I have -no- idea what that means in this case.

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Attempt-to-fix-issue-with-escaped-entities-in-RSS-10262-3d64c3efd8e148aeafa77b300667600f

@michelle0927 michelle0927 merged commit 09543c0 into PipedreamHQ:master Feb 19, 2024
8 checks passed
luiidd pushed a commit to luiidd/pipedream that referenced this pull request Mar 7, 2024
* Attempt to fix issue with escaped entities in RSS

* Updated version numbers of dependent items

* Updated a version again

* Check for item existance, thx to @michelle0927

* update

---------

Co-authored-by: michelle0927 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee User submitted Submitted by a user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants