-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[Components] paddle #10926 #18510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lcaresia
wants to merge
1
commit into
master
Choose a base branch
from
issue-10926
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Components] paddle #10926 #18510
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
components/paddle/actions/create-customer/create-customer.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import app from "../../paddle.app.mjs"; | ||
|
||
export default { | ||
key: "paddle-create-customer", | ||
name: "Create Customer", | ||
description: "Create a new customer in Paddle. [See the documentation](https://developer.paddle.com/api-reference/customers/create-customer)", | ||
version: "0.0.1", | ||
type: "action", | ||
props: { | ||
app, | ||
email: { | ||
propDefinition: [ | ||
app, | ||
"email", | ||
], | ||
}, | ||
name: { | ||
propDefinition: [ | ||
app, | ||
"name", | ||
], | ||
}, | ||
customData: { | ||
propDefinition: [ | ||
app, | ||
"customData", | ||
], | ||
}, | ||
}, | ||
async run({ $ }) { | ||
const response = await this.app.createCustomer({ | ||
$, | ||
data: { | ||
email: this.email, | ||
name: this.name, | ||
custom_data: this.customData, | ||
}, | ||
}); | ||
$.export("$summary", "Successfully created a new customer with the ID: " + response.data.id); | ||
return response; | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import app from "../../paddle.app.mjs"; | ||
|
||
export default { | ||
key: "paddle-get-customers", | ||
name: "Get Customers", | ||
description: "Get a list of customers registered in Paddle. [See the documentation](https://developer.paddle.com/api-reference/customers/list-customers)", | ||
version: "0.0.1", | ||
type: "action", | ||
props: { | ||
app, | ||
}, | ||
async run({ $ }) { | ||
const response = await this.app.getCustomers({ | ||
$, | ||
}); | ||
$.export("$summary", "Successfully retrieved " + response.data.length + " customers"); | ||
return response; | ||
}, | ||
}; |
56 changes: 56 additions & 0 deletions
56
components/paddle/actions/update-customer/update-customer.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import app from "../../paddle.app.mjs"; | ||
|
||
export default { | ||
key: "paddle-update-customer", | ||
name: "Update Customer", | ||
description: "Update the customer with the specified ID. [See the documentation](https://developer.paddle.com/api-reference/customers/update-customer)", | ||
version: "0.0.1", | ||
type: "action", | ||
props: { | ||
app, | ||
customerId: { | ||
propDefinition: [ | ||
app, | ||
"customerId", | ||
], | ||
}, | ||
email: { | ||
propDefinition: [ | ||
app, | ||
"email", | ||
], | ||
}, | ||
name: { | ||
propDefinition: [ | ||
app, | ||
"name", | ||
], | ||
}, | ||
customData: { | ||
propDefinition: [ | ||
app, | ||
"customData", | ||
], | ||
}, | ||
status: { | ||
propDefinition: [ | ||
app, | ||
"status", | ||
], | ||
}, | ||
}, | ||
async run({ $ }) { | ||
const response = await this.app.updateCustomer({ | ||
$, | ||
customerId: this.customerId, | ||
data: { | ||
email: this.email, | ||
name: this.name, | ||
custom_data: this.customData, | ||
status: this.status, | ||
}, | ||
}); | ||
$.export("$summary", "Successfully updated the customer with ID: " + this.customerId); | ||
return response; | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export default { | ||
STATUS_OPTIONS: [ | ||
"active", | ||
"archived", | ||
], | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/paddle", | ||
"version": "0.0.1", | ||
"version": "0.1.0", | ||
"description": "Pipedream Paddle Components", | ||
"main": "paddle.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,92 @@ | ||
import { axios } from "@pipedream/platform"; | ||
import constants from "./common/constants.mjs"; | ||
|
||
export default { | ||
type: "app", | ||
app: "paddle", | ||
propDefinitions: {}, | ||
propDefinitions: { | ||
email: { | ||
type: "string", | ||
label: "Email", | ||
description: "Customer's email address", | ||
}, | ||
name: { | ||
type: "string", | ||
label: "Name", | ||
description: "Customer's full name", | ||
}, | ||
customData: { | ||
type: "object", | ||
label: "Custom Data", | ||
description: "Your own structured key-value data", | ||
optional: true, | ||
}, | ||
status: { | ||
type: "string", | ||
label: "Status", | ||
description: "Customer's status", | ||
options: constants.STATUS_OPTIONS, | ||
}, | ||
customerId: { | ||
type: "string", | ||
label: "Customer ID", | ||
description: "Unique identifier of the customer", | ||
async options() { | ||
const response = await this.getCustomers(); | ||
const data = response.data; | ||
return data.map(({ | ||
id, name, | ||
}) => ({ | ||
value: id, | ||
label: name, | ||
})); | ||
}, | ||
}, | ||
}, | ||
methods: { | ||
// this.$auth contains connected account data | ||
authKeys() { | ||
console.log(Object.keys(this.$auth)); | ||
_baseUrl() { | ||
return "https://sandbox-api.paddle.com"; | ||
}, | ||
async _makeRequest(opts = {}) { | ||
const { | ||
$ = this, | ||
path, | ||
headers, | ||
...otherOpts | ||
} = opts; | ||
return axios($, { | ||
...otherOpts, | ||
url: this._baseUrl() + path, | ||
headers: { | ||
Authorization: `Bearer ${this.$auth.auth_code}`, | ||
...headers, | ||
}, | ||
}); | ||
}, | ||
|
||
async getCustomers(args = {}) { | ||
return this._makeRequest({ | ||
path: "/customers", | ||
...args, | ||
}); | ||
}, | ||
GTFalcao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
async createCustomer(args = {}) { | ||
return this._makeRequest({ | ||
path: "/customers", | ||
method: "post", | ||
...args, | ||
}); | ||
}, | ||
|
||
async updateCustomer({ | ||
customerId, ...args | ||
}) { | ||
return this._makeRequest({ | ||
path: `/customers/${customerId}`, | ||
method: "patch", | ||
...args, | ||
}); | ||
}, | ||
GTFalcao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
}; | ||
}; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
CRITICAL: Hardcoded sandbox API URL blocks production usage.
The base URL is hardcoded to Paddle's sandbox environment. This makes the integration unusable in production. The URL should be configurable or determined by the authentication configuration.
Apply this diff to make the environment configurable:
Alternatively, if the auth configuration doesn't include an environment field, you may need to add a separate prop or configuration option.
🌐 Web query:
💡 Result:
Production (live) API base URL: https://api.paddle.com. [1]
Sandbox API base URL: https://sandbox-api.paddle.com. [1]
How integrations typically handle sandbox vs production
Sources: Paddle developer docs (sandbox & base URLs, API keys, SDK environment, go‑live checklist). [1][2][3][4]
CRITICAL — hardcoded sandbox API URL; make base URL environment-configurable
File: components/paddle/paddle.app.mjs (lines 47–49) — _baseUrl() currently returns "https://sandbox-api.paddle.com". Production base URL is "https://api.paddle.com" and sandbox/live credentials are not interchangeable (mismatched key+URL returns 403). Replace with environment/config-driven selection (default to production). Example:
Document PADDLE_ENV/PADDLE_BASE_URL and ensure sandbox vs live credentials are switched together.
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right - please check if the base URL is intended to be
sandbox-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 24040
@GTFalcao You're absolutely right to flag this! 🎯
After examining the codebase, this is indeed incorrect. The base URL should be the production API (
https://api.paddle.com
), not the sandbox URL.Evidence:
All other app integrations in this repository use production URLs by default:
big_data_cloud
:https://api-bdc.net/data
change_photos
:https://www.change.photos/api
code_climate
:https://api.codeclimate.com/v1
cutt_ly
:https://cutt.ly/api
Paddle's API documentation confirms:
https://api.paddle.com
https://sandbox-api.paddle.com
(for testing only)Using sandbox by default would make this integration unusable in production without modifying the code.
Recommendation:
If sandbox support is needed for development/testing, consider making it configurable through an environment variable or auth configuration, but production should always be the default.