Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start changing readme to PirateWeather and add CONTRIBUTING file #9

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

cloneofghosts
Copy link
Collaborator

Describe the change

Changes the Dark Sky references in the readme file to Pirate Weather and moves the development content into CONTRIBUTING.md. @alexander0042 Do we want to remove the link to their kickstarter or should we leave it there as this module is a fork of their module.

Also since PW hasn't had the summaries since the start so I changed the sentence to show what version it was added. But since it has yet to be added I just set the version to 2.x.

Type of change

  • New translation
  • Translation update
  • Code quality improvements to existing code or addition of tests
  • Documentation Updates

Checklist

  • This pull request fixes issue: fixes #
  • Link to documentation pull request in the API repo:
  • Tests have been added for the new language
  • Tests pasts locally. Your pull request won't be merged unless tests pass
  • Code has been formatted using eslint (npm run lint)

Sorry, something went wrong.

@cloneofghosts cloneofghosts added documentation Improvements or additions to documentation Needs Review labels Oct 23, 2024
@cloneofghosts cloneofghosts marked this pull request as ready for review October 30, 2024 19:52
@cloneofghosts cloneofghosts merged commit e88eebe into master Nov 18, 2024
7 checks passed
@cloneofghosts cloneofghosts deleted the update-readme branch November 18, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant