Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to FindCUDAToolkit #1329

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RedL0tus
Copy link

@RedL0tus RedL0tus commented Mar 13, 2024

  • FindCUDA has been deprecated since CMake 3.10, and disabled by default since CMake 3.27. 1
  • Raise CMAKE_MINIMUM_REQUIRED to 3.23 for CMAKE_CUDA_ARCHITECTURES support. 2

Footnotes

  1. https://cmake.org/cmake/help/latest/policy/CMP0146.html

  2. https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html

- FindCUDA has been deprecated since CMake 3.10, and disabled by default since
  CMake 3.27. [^1]
- Raise CMAKE_MINIMUM_REQUIRED to 3.23 for CMAKE_CUDA_ARCHITECTURES
  support. [^2]

[^1]: https://cmake.org/cmake/help/latest/policy/CMP0146.html
[^2]: https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html
@davidgyu
Copy link
Member

Filed as internal issue #OSD-436

@RedL0tus
Copy link
Author

PixarAnimationStudios.OpenSubdiv (macOS) Failing after 13s — macOS failed

Judging from the log:

/bin/bash --noprofile --norc /Users/runner/work/_temp/4a641c5b-5932-47b6-9975-7d6d26e3535f.sh
/Users/runner/work/1/s/build_scripts/build_osd.py:122: SyntaxWarning: invalid escape sequence '\d'
  "(\d+).(\d+)",
Traceback (most recent call last):
  File "/Users/runner/work/1/s/build_scripts/build_osd.py", line 26, in <module>
    from distutils.spawn import find_executable
ModuleNotFoundError: No module named 'distutils'

Looks like there's something wrong with the macOS CI configuration...?

@davidgyu
Copy link
Member

You're right. It looks like something has changed on the macOS-11 configs. I've filed #1330 for us to follow up with a fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants