Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connected theta edges for plot3d #1237

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Fix connected theta edges for plot3d #1237

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11fe44b
fix connected theta edges for plot3d
YigitElma Aug 31, 2024
add23cd
do same fix for 2pi zeta case
YigitElma Aug 31, 2024
f1af4e2
Merge branch 'master' into yge/plot3d
YigitElma Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desc/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,9 +971,9 @@
if grid.num_rho == 1:
n1, n2 = grid.num_theta, grid.num_zeta
if not grid.nodes[-1][2] == 2 * np.pi:
p1, p2 = True, False
p1, p2 = False, False

Check warning on line 974 in desc/plotting.py

View check run for this annotation

Codecov / codecov/patch

desc/plotting.py#L974 

Added line #L974 was not covered by tests
else:
p1, p2 = True, True
p1, p2 = False, True
elif grid.num_theta == 1:
n1, n2 = grid.num_rho, grid.num_zeta
p1, p2 = False, True
Expand Down
Loading