Resolves #1240 #1241
Merged
Resolves #1240 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +1.53 +/- 8.43 | +7.87e-03 +/- 4.33e-02 | 5.22e-01 +/- 4.2e-02 | 5.14e-01 +/- 1.1e-02 |
test_equilibrium_init_medres | +1.32 +/- 0.65 | +5.36e-02 +/- 2.62e-02 | 4.10e+00 +/- 1.7e-02 | 4.04e+00 +/- 2.0e-02 |
test_equilibrium_init_highres | +1.43 +/- 0.83 | +7.64e-02 +/- 4.47e-02 | 5.44e+00 +/- 2.1e-02 | 5.36e+00 +/- 3.9e-02 |
test_objective_compile_dshape_current | +0.93 +/- 1.00 | +3.52e-02 +/- 3.80e-02 | 3.82e+00 +/- 2.6e-02 | 3.78e+00 +/- 2.8e-02 |
test_objective_compute_dshape_current | -0.56 +/- 1.95 | -1.94e-05 +/- 6.72e-05 | 3.43e-03 +/- 4.8e-05 | 3.45e-03 +/- 4.7e-05 |
test_objective_jac_dshape_current | +3.04 +/- 6.13 | +1.21e-03 +/- 2.44e-03 | 4.10e-02 +/- 1.9e-03 | 3.98e-02 +/- 1.5e-03 |
test_perturb_2 | +0.94 +/- 1.32 | +1.60e-01 +/- 2.24e-01 | 1.72e+01 +/- 1.7e-01 | 1.70e+01 +/- 1.4e-01 |
test_proximal_freeb_jac | +1.20 +/- 1.04 | +8.85e-02 +/- 7.61e-02 | 7.44e+00 +/- 6.4e-02 | 7.35e+00 +/- 4.1e-02 |
test_solve_fixed_iter | +1.50 +/- 61.08 | +7.33e-02 +/- 2.98e+00 | 4.96e+00 +/- 2.1e+00 | 4.88e+00 +/- 2.2e+00 | |
unalmis
requested review from
a team,
rahulgaur104,
f0uriest,
ddudt,
dpanici,
kianorr,
sinaatalay and
YigitElma
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 95.45% 95.45% -0.01%
==========================================
Files 95 95
Lines 23406 23402 -4
==========================================
- Hits 22342 22338 -4
Misses 1064 1064
|
f0uriest
approved these changes
Sep 5, 2024
dpanici
reviewed
Sep 5, 2024
| @@ -11,8 +11,8 @@ | |||
|
|
|||
| from desc.backend import jnp | |||
|
|
|||
| from ..utils import cross, dot, safediv | |||
There was a problem hiding this comment.
why do we not do desc.utils here? or is this equivalent?
There was a problem hiding this comment.
it's equivalent. this is what Pycharm's automated refactoring chose.
dpanici
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.