-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing ε and Γ_c compute funs with new methods #1290
Draft
unalmis
wants to merge
313
commits into
ku/fourier_bounce
Choose a base branch
from
ku/fourier_bounce_neo
base: ku/fourier_bounce
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…don't matter for effective ripple and we save memory and speed, and makes differentiating easier
unalmis
changed the title
Writing neoclassical functions to use pseudospectral methods
Writing ε¹ᐧ⁵ and Γ_c compute funs with new methods
Oct 3, 2024
unalmis
changed the title
Writing ε¹ᐧ⁵ and Γ_c compute funs with new methods
Writing ε and Γ_c compute funs with new methods
Oct 3, 2024
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +7.57 +/- 9.25 | +3.96e-02 +/- 4.84e-02 | 5.63e-01 +/- 4.8e-02 | 5.23e-01 +/- 5.4e-03 |
test_equilibrium_init_medres | -0.67 +/- 1.68 | -2.76e-02 +/- 6.89e-02 | 4.07e+00 +/- 6.4e-02 | 4.10e+00 +/- 2.6e-02 |
test_equilibrium_init_highres | -0.65 +/- 3.02 | -3.58e-02 +/- 1.66e-01 | 5.48e+00 +/- 3.1e-02 | 5.52e+00 +/- 1.6e-01 |
test_objective_compile_dshape_current | +4.35 +/- 5.85 | +1.61e-01 +/- 2.17e-01 | 3.87e+00 +/- 3.6e-02 | 3.70e+00 +/- 2.1e-01 |
test_objective_compute_dshape_current | -0.38 +/- 1.60 | -1.36e-05 +/- 5.78e-05 | 3.60e-03 +/- 5.1e-05 | 3.61e-03 +/- 2.7e-05 |
test_objective_jac_dshape_current | +0.57 +/- 7.26 | +2.26e-04 +/- 2.87e-03 | 3.98e-02 +/- 1.9e-03 | 3.96e-02 +/- 2.1e-03 |
test_perturb_2 | -0.11 +/- 1.99 | -1.88e-02 +/- 3.48e-01 | 1.75e+01 +/- 1.9e-01 | 1.75e+01 +/- 2.9e-01 |
test_proximal_freeb_jac | +0.01 +/- 0.98 | +8.71e-04 +/- 7.28e-02 | 7.44e+00 +/- 6.5e-02 | 7.44e+00 +/- 3.2e-02 |
test_solve_fixed_iter | -1.64 +/- 58.27 | -8.39e-02 +/- 2.98e+00 | 5.03e+00 +/- 2.1e+00 | 5.12e+00 +/- 2.1e+00 |
test_build_transform_fft_midres | +1.54 +/- 3.14 | +1.03e-02 +/- 2.10e-02 | 6.77e-01 +/- 1.6e-02 | 6.67e-01 +/- 1.3e-02 |
test_build_transform_fft_highres | +2.40 +/- 2.19 | +2.53e-02 +/- 2.30e-02 | 1.08e+00 +/- 1.9e-02 | 1.05e+00 +/- 1.3e-02 |
test_equilibrium_init_lowres | +4.20 +/- 3.24 | +1.82e-01 +/- 1.40e-01 | 4.52e+00 +/- 1.2e-01 | 4.34e+00 +/- 7.1e-02 |
test_objective_compile_atf | +7.61 +/- 4.45 | +5.98e-01 +/- 3.50e-01 | 8.46e+00 +/- 2.8e-01 | 7.86e+00 +/- 2.1e-01 |
test_objective_compute_atf | +2.77 +/- 2.63 | +2.94e-04 +/- 2.80e-04 | 1.09e-02 +/- 1.9e-04 | 1.06e-02 +/- 2.1e-04 |
test_objective_jac_atf | +1.97 +/- 2.05 | +3.91e-02 +/- 4.07e-02 | 2.02e+00 +/- 2.9e-02 | 1.98e+00 +/- 2.9e-02 |
-test_perturb_1 | +12.59 +/- 3.02 | +1.59e+00 +/- 3.83e-01 | 1.43e+01 +/- 3.4e-01 | 1.27e+01 +/- 1.9e-01 |
test_proximal_jac_atf | +1.75 +/- 0.93 | +1.42e-01 +/- 7.54e-02 | 8.29e+00 +/- 5.9e-02 | 8.15e+00 +/- 4.7e-02 |
test_proximal_freeb_compute | +2.00 +/- 1.27 | +3.71e-03 +/- 2.36e-03 | 1.89e-01 +/- 2.1e-03 | 1.85e-01 +/- 1.1e-03 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new compute functions for
Gamma_c
andeffective ripple
using the numerical methods in #1119.*
to the compute quantity name)Notes
I won't get to this until next week. If someone needs this before then, feel free to try out. Basically the compute function will no longer have
source grid requirement
, justgrid requirement = meshgrid
then useBounce2D
as in the examples intest/integrals
on #1119.