Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib requirement from <=3.9.3,>=3.5.0 to >=3.5.0,<=3.10.0 #1470

Merged
merged 11 commits into from
Jan 27, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Updates the requirements on matplotlib to permit the latest version.

Release notes

Sourced from matplotlib's releases.

REL: v3.10.0

Highlights of this release include:

- Preliminary support for free-threaded CPython 3.13
- Standard getters/setters for axis inversion state
- New more-accessible color cycle
- Dark-mode diverging colormaps
- Exception handling control
- InsetIndicator artist
- FillBetweenPolyCollection
- Fill between 3D lines
- Data in 3D plots can now be dynamically clipped to the axes view limits
- Rotating 3d plots with the mouse
- Increased Figure limits with Agg renderer
- Subfigures no longer provisional
- Subfigures are now added in row-major order
Commits
  • 8d64f03 REL: v3.10.0 release
  • d9dfee8 [doc] Fix dead links
  • 87a603f Update release notes for 3.10.0
  • cdecf97 Update github stats for 3.10
  • b8d19bd Merge pull request #29306 from meeseeksmachine/auto-backport-of-pr-29242-on-v...
  • a42d0ed Backport PR #29242: DOC: Add kwdoc list to scatter() docstring
  • 1900640 Merge pull request #29299 from QuLogic/merge-v39x
  • 815389c Merge branch 'v3.9.x' into v3.10.x
  • 73873c0 DOC: Create release notes for 3.9.4
  • 9d17a2b DOC: Add Zenodo DOI for 3.9.4
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [matplotlib](https://github.com/matplotlib/matplotlib) to permit the latest version.
- [Release notes](https://github.com/matplotlib/matplotlib/releases)
- [Commits](matplotlib/matplotlib@v3.5.0...v3.10.0)

---
updated-dependencies:
- dependency-name: matplotlib
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Issue related to libraries we depend on and how we interface with them python Pull requests that update Python code labels Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -5.62 +/- 9.14     | -3.16e-02 +/- 5.15e-02 |  5.31e-01 +/- 3.7e-02  |  5.63e-01 +/- 3.5e-02  |
 test_equilibrium_init_medres            |     -6.53 +/- 4.73     | -2.90e-01 +/- 2.10e-01 |  4.15e+00 +/- 1.1e-01  |  4.44e+00 +/- 1.8e-01  |
 test_equilibrium_init_highres           |     -7.39 +/- 3.08     | -4.32e-01 +/- 1.80e-01 |  5.41e+00 +/- 5.0e-02  |  5.84e+00 +/- 1.7e-01  |
 test_objective_compile_dshape_current   |     -7.45 +/- 4.01     | -3.29e-01 +/- 1.77e-01 |  4.09e+00 +/- 1.3e-01  |  4.42e+00 +/- 1.2e-01  |
 test_objective_compute_dshape_current   |     -0.03 +/- 2.06     | -1.77e-06 +/- 1.06e-04 |  5.15e-03 +/- 8.0e-05  |  5.15e-03 +/- 6.9e-05  |
 test_objective_jac_dshape_current       |     -3.93 +/- 7.63     | -1.73e-03 +/- 3.37e-03 |  4.24e-02 +/- 2.2e-03  |  4.42e-02 +/- 2.5e-03  |
 test_perturb_2                          |     -2.00 +/- 5.17     | -4.04e-01 +/- 1.04e+00 |  1.98e+01 +/- 2.7e-01  |  2.02e+01 +/- 1.0e+00  |
 test_proximal_freeb_jac                 |     +0.69 +/- 5.08     | +5.17e-02 +/- 3.84e-01 |  7.60e+00 +/- 1.7e-01  |  7.55e+00 +/- 3.4e-01  |
 test_solve_fixed_iter                   |     -0.47 +/- 4.43     | -1.56e-01 +/- 1.46e+00 |  3.29e+01 +/- 8.3e-01  |  3.31e+01 +/- 1.2e+00  |
 test_LinearConstraintProjection_build   |     -1.61 +/- 3.90     | -1.75e-01 +/- 4.26e-01 |  1.08e+01 +/- 3.1e-01  |  1.09e+01 +/- 2.9e-01  |
 test_build_transform_fft_midres         |     -4.57 +/- 3.33     | -2.92e-02 +/- 2.13e-02 |  6.10e-01 +/- 1.8e-02  |  6.40e-01 +/- 1.1e-02  |
 test_build_transform_fft_highres        |     -2.69 +/- 3.71     | -2.70e-02 +/- 3.72e-02 |  9.74e-01 +/- 3.3e-02  |  1.00e+00 +/- 1.7e-02  |
 test_equilibrium_init_lowres            |     -6.02 +/- 7.77     | -2.49e-01 +/- 3.21e-01 |  3.88e+00 +/- 4.8e-02  |  4.13e+00 +/- 3.2e-01  |
 test_objective_compile_atf              |     -2.35 +/- 5.16     | -2.01e-01 +/- 4.40e-01 |  8.33e+00 +/- 2.2e-01  |  8.54e+00 +/- 3.8e-01  |
 test_objective_compute_atf              |     -0.94 +/- 3.19     | -1.50e-04 +/- 5.09e-04 |  1.58e-02 +/- 2.8e-04  |  1.60e-02 +/- 4.3e-04  |
 test_objective_jac_atf                  |     -0.58 +/- 2.70     | -1.13e-02 +/- 5.24e-02 |  1.93e+00 +/- 4.1e-02  |  1.94e+00 +/- 3.2e-02  |
 test_perturb_1                          |     +1.09 +/- 4.99     | +1.68e-01 +/- 7.66e-01 |  1.55e+01 +/- 2.3e-01  |  1.54e+01 +/- 7.3e-01  |
 test_proximal_jac_atf                   |     -0.91 +/- 1.43     | -7.52e-02 +/- 1.19e-01 |  8.23e+00 +/- 6.2e-02  |  8.30e+00 +/- 1.0e-01  |
 test_proximal_freeb_compute             |     -0.87 +/- 1.54     | -1.74e-03 +/- 3.10e-03 |  2.00e-01 +/- 1.2e-03  |  2.01e-01 +/- 2.9e-03  |
 test_solve_fixed_iter_compiled          |     +0.02 +/- 1.74     | +4.11e-03 +/- 3.59e-01 |  2.06e+01 +/- 2.9e-01  |  2.06e+01 +/- 2.1e-01  |

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (5322158) to head (e693b12).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1470   +/-   ##
=======================================
  Coverage   95.68%   95.69%           
=======================================
  Files         101      101           
  Lines       25604    25610    +6     
=======================================
+ Hits        24500    24507    +7     
+ Misses       1104     1103    -1     
Files with missing lines Coverage Δ
desc/plotting.py 95.95% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@YigitElma YigitElma added skip_changelog No need to update changelog on this PR test_mpl labels Dec 16, 2024
@YigitElma
Copy link
Collaborator

Seems like there is a depreciation warning causing pytest to fail. https://github.com/PlasmaControl/DESC/actions/runs/12360091121/job/34494232965?pr=1470

@f0uriest
Copy link
Member

I think we already have a wrapper function for the tight layout which is causing the warning, probably just need to add another case to it

@YigitElma
Copy link
Collaborator

I should change the mpl test as it is for jax.

@dpanici
Copy link
Collaborator

dpanici commented Jan 15, 2025

@YigitElma update on this?

@dpanici
Copy link
Collaborator

dpanici commented Jan 22, 2025

Test this locally (like for API change etc)

@YigitElma
Copy link
Collaborator

YigitElma commented Jan 24, 2025

This is the failing one with 3.10.0,

test_plot_basis_fourierseries copy

and this is the same one, we currently have in baseline images,

test_plot_basis_fourierseries

I think they are basically the same but one of them is slightly wider.

@YigitElma YigitElma requested review from a team and removed request for a team January 24, 2025 00:16
@dpanici
Copy link
Collaborator

dpanici commented Jan 24, 2025

I think that's fine then, I approve

@YigitElma
Copy link
Collaborator

We can update the baseline image later. The CI will still use the 3.9.3

@YigitElma YigitElma merged commit 7e98f16 into master Jan 27, 2025
39 of 51 checks passed
@YigitElma YigitElma deleted the dependabot/pip/matplotlib-gte-3.5.0-and-lte-3.10.0 branch January 27, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue related to libraries we depend on and how we interface with them python Pull requests that update Python code skip_changelog No need to update changelog on this PR test_mpl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants