Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create plasmo from existing manifest #224

Merged
merged 3 commits into from
Sep 22, 2022
Merged

feat: create plasmo from existing manifest #224

merged 3 commits into from
Sep 22, 2022

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Sep 21, 2022 •
edited
Loading

Details

  • This PR migrates a lot of the manifest prop from mv2 -> plasmo override
  • Need a follow-up PR to create some place-holder entry files
  • closes #
  • If RFC, it has been approved for implementation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current PR for duplication.

@louisgv louisgv linked an issue Sep 21, 2022 that may be closed by this pull request
[RFC] Initialize a Plasmo project from an existing extension manifest #147
Closed
3 tasks
@louisgv louisgv requested a review from ColdSauce September 21, 2022 21:04
@louisgv louisgv marked this pull request as ready for review September 21, 2022 21:04
@louisgv louisgv merged commit e06db66 into main Sep 22, 2022
@louisgv louisgv deleted the 147-rfc-mv2-to-plasmo branch September 22, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdSauce ColdSauce ColdSauce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Initialize a Plasmo project from an existing extension manifest
2 participants
@louisgv @ColdSauce