Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amend button permissions #15

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix amend button permissions #15

merged 2 commits into from
Dec 20, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Dec 20, 2023

The "amend" button in the list of proposals after importing from participatory texts doesn't follow the configured permissions allowing every user to amend the proposal even when they have no permission.

Screenshot 2023-12-20 at 17 33 06

It's a decidim bug, but we have monkey-patched it here to fix it ASAP, and we will work on a fix for decidim anytime soon.

@fblupi fblupi added the bug Something isn't working label Dec 20, 2023
@fblupi fblupi requested a review from rxnetwalker December 20, 2023 16:32
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db5f6db) 71.64% compared to head (af641c5) 71.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   71.64%   71.64%           
=======================================
  Files           9        9           
  Lines          67       67           
=======================================
  Hits           48       48           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fblupi fblupi merged commit d288283 into main Dec 20, 2023
@fblupi fblupi deleted the fix/amend-button-permissions branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants