-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for missing documentation #727
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall idea sounds reasonable. Considering src/
(maybe plume-cli
) also contains some non trivial code (remember url! in the custom domain PR?), I think doing it would make sense to apply that on them too
You should add a feature to all crates, and replace current attribute with #![cfg_attr(not(feature = "ci"), warn(missing_docs))]
(which would be set in CI). That way it won't fail on the deny(warnings) on clippy
can't we add that that somewhere to |
Isn't there a better way to allow just these warnings in clippy? |
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 39.17% 39.15% -0.03%
==========================================
Files 73 73
Lines 9653 9653
Branches 2183 2182 -1
==========================================
- Hits 3782 3780 -2
Misses 4819 4819
- Partials 1052 1054 +2 |
To force us to document our code.
I didn't added it to binaries (
src/
andplume-cli/
because it didn't really made sense for them IMO), but I can.Also, to keep this PR small, I propose that we slowly document each function as we modify them in other PRs. Does it seem reasonable to you?