snap: Fix build process for Tier 2 platforms #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this only actually *fixes* the build for arm64; it seems that we hit various bugs in Rust on ppc64 and armhf.
igalic
reviewed
Jan 24, 2020
| - on arm64,armhf,ppc64el,s390x: | ||
| - lld-8 | ||
| - libclang-9-dev | ||
| - lld-9 |
There was a problem hiding this comment.
maybe we should get rid of these dependencies again, so we can have broader platform support
There was a problem hiding this comment.
These actuality exist everywhere (on Linux); I just dropped the (attempted) “only install lld on tier 2 platforms” logic.
With lld-9 the build failures on ppc64 and armhf are elsewhere.
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
==========================================
- Coverage 39.16% 38.99% -0.18%
==========================================
Files 73 73
Lines 9653 9701 +48
Branches 2183 2229 +46
==========================================
+ Hits 3781 3783 +2
+ Misses 4819 4756 -63
- Partials 1053 1162 +109 |
should we wait for these bugs to be fixed, or can we merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this only actually fixes the build for arm64;
it seems that we hit various bugs in Rust on ppc64 and armhf.