Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Uniform /status format #3220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Uniform /status format #3220

wants to merge 2 commits into from

Conversation

msjyoo
Copy link
Member

@msjyoo msjyoo commented Jun 24, 2015

Remove trailing dot for uniform /status command for easier parsing

@msjyoo msjyoo added the C: Core label Jun 24, 2015
@shoghicp
Copy link
Member

Easier parsing, but you broke the existing parsing.

This was done to copy the format used in PC and other plugins (so existing code would be compatible with it), this now breaks compatibility with them completely.

@msjyoo
Copy link
Member Author

msjyoo commented Jun 24, 2015

Are you serious right now, this is starting to feel like Microsoft on their backward compatibility motto.. (oh wait! :P)

Examples that this format is used in PC and will result in serious stuff braking?

@shoghicp
Copy link
Member

Anyway, this does not make parsing "easier", it's the same, just an extra character.
/^([^:]+): ([^\.]+)\.$/ with dot
/^([^:]+): (.+)$/ without dot

then remove the special chars and you have everything split by key and value

@msjyoo
Copy link
Member Author

msjyoo commented Jun 25, 2015

sigh Why would you even make a commit with MBs with dots appended and Kb/s without a dot appended? This is a fix, not "breaking backwards compatibility"... I don't understand how an issue as critical as an unnecessary dot being appended taking up 4 extra bytes doesn't come across as an issue that requires IMMEDIATE fixing?!

It literally BURNS my eyes every time I run the status command, and I weep at the lack of uniformity between the lines how can you not see this as a problem it needs to be FIXED NOW!!!111

@msjyoo
Copy link
Member Author

msjyoo commented Jun 25, 2015

Whoops, I seem to have dropped this -> /s

@msjyoo
Copy link
Member Author

msjyoo commented Aug 8, 2015

@shoghicp Any update on this? It makes sense to drop the period.

@msjyoo msjyoo self-assigned this Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants