Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Zink Renderer - Remove VirGL #4242

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

thejudge156
Copy link
Contributor

@thejudge156 thejudge156 commented Jun 1, 2023

Introduces the Zink renderer. I do need a tester for this as both of my devices do not support logic op without changes to Zink. If someone with an Android 13 device could test this that would be fabulous.

Currently, on my testing device the game loads, but its only red, I assume logicop is the cause of that issue, but as far as that is concerned, it should work on some devices. I will be adding a Device Compat checker so you are notified if your device can use Zink.

I will add new binaries as I compile them.

@abhishekgi
Copy link

abhishekgi commented Jun 2, 2023

Nice !
finally zink is back
My device is on android 12
It has Mali gpu
I can test zink

@selut06
Copy link

selut06 commented Jun 2, 2023

well, good for you Mali gpus
rip adreno

@abhishekgi
Copy link

abhishekgi commented Jun 2, 2023

Couldn't both zink and virgl exist together in pojavlauncher?

@selut06
Copy link

selut06 commented Jun 2, 2023

no virgl is sucks, so they wanna bring back zinkvulkan and make it running well on adreno gpus

@abhishekgi
Copy link

abhishekgi commented Jun 2, 2023

no virgl is sucks, so they wanna bring back zinkvulkan and make it running well on adreno gpus

So why you Andreno gpu play in peace

what?

Mean Andreno gpu will not rest in peace.
As they are making zink compatible for andreno

@selut06
Copy link

selut06 commented Jun 2, 2023

what?

@abhishekgi
Copy link

what?

BTW what is your country’s name

@selut06
Copy link

selut06 commented Jun 2, 2023

no

@jtghph
Copy link
Contributor

jtghph commented Jun 2, 2023

Nice ! finally zink is back My device is on android 12 It has Mali gpu I can test zink

The above PR statement says Android 13, not 12.

@jtghph
Copy link
Contributor

jtghph commented Jun 2, 2023

Couldn't both zink and virgl exist together in pojavlauncher?

It will just induce more bloat on source-side and app-side, which is what we're currently trying to avoid.

@Dawimpy
Copy link

Dawimpy commented Jun 2, 2023

Nice ! finally zink is back My device is on android 12 It has Mali gpu I can test zink

The above PR statement says Android 13, not 12.

So thats mean android12 dont work?

@thejudge156
Copy link
Contributor Author

Nice ! finally zink is back My device is on android 12 It has Mali gpu I can test zink

The above PR statement says Android 13, not 12.

I just wanted to make sure Android 13 worked, but android 7+ should work if they have the right extensions.

@jtghph
Copy link
Contributor

jtghph commented Jun 3, 2023

Speaking of which you mentioned LogicOP, which VK extension is sufficient to make it work?

@thejudge156
Copy link
Contributor Author

It is a device feature, not an extension

@Eggir
Copy link

Eggir commented Jun 4, 2023

I can test
My device is on android 13 (Poco X4 GT), (Dimensity 8100) Mali-G610 MC6
Already checked on version 1.7.10, crashes without errors. Version 1.12.2 launches at 20-30 FPS.

@unilock
Copy link

unilock commented Jun 5, 2023

I tested vanilla 1.19.4 on my Pixel 6 Pro (w/ Android 13). It loaded to a red screen (the loading screen, but without the Mojang logo or progress bar), then crashed.

latestlog.txt: https://gist.github.com/unilock/9f511758498151a3f4fdd329cea1f9e3

@SolDev69
Copy link
Contributor

SolDev69 commented Jun 5, 2023

I can do testing, just please get armhf working.

@Mario191209
Copy link

I've tested this version with my phone (Dimensity 1200 with Mali G77-MC9) and it doesn't crash at all

@SolDev69
Copy link
Contributor

SolDev69 commented Jun 9, 2023

Can probably be closed now with #4246 being worked on.

@cyriotic3
Copy link

Can probably be closed now with #4246 being worked on.

this one works better for me (with crashes), #4246 has this weird lag for me

Android 12, Exynos (Mali)

@Kanjiharuto
Copy link

Vulkan zink not showing on my device (realme c55/android 13/vulkan supported) , in pojavlauncher Show only zink , not vulkan zink like on other devices

@Mario191209
Copy link

can you show me a screenshot?

@Kanjiharuto
Copy link

can you show me a screenshot?

Screenshot_2023-07-13-13-29-10-84_67a64f1fc1b88908dad3392f76c1969b
Screenshot_2023-07-13-13-28-50-18_ec26a5b067f1f280d42a6939e557a45a
Screenshot_2023-07-13-13-28-43-38_ec26a5b067f1f280d42a6939e557a45a

@Mario191209
Copy link

Mario191209 commented Jul 13, 2023

Bruh, Zink is a renderer, If your phone support vulkan then the zink renderer work for your device (Adreno doesn't work unless you update the vulkan driver to 1.3)

@Mario191209
Copy link

or using turnip driver

@Mario191209
Copy link

it work with mali (some model will crash because of missing extensions

@Mario191209
Copy link

Zink = Vulkan + OpenGL

@Kanjiharuto
Copy link

nó hoạt động với mali (một số mô hình sẽ gặp sự cố do thiếu tiện ích mở rộng

My device is not adreno but mali(Mali-G52 mc2) but it also doesn't work

@Mario191209
Copy link

example :
Uploading Screenshot_2023-07-13-14-52-38-803_com.finalwire.aida64.jpg…

@Mario191209
Copy link

damn my internet

@Kanjiharuto
Copy link

damn my internet

I still haven't seen the picture you sent?

@Mario191209
Copy link

Screenshot_2023-07-13-14-52-38-803_com finalwire aida64

@Mario191209
Copy link

those are Vulkan extensions

@Mario191209
Copy link

It's required VK_KHR_imageless_framebuffer and timeline semaphore

@Mario191209
Copy link

if your phone doesn't have, then it not supported with your vulkan driver

@Mario191209
Copy link

send log

@Mario191209
Copy link

Increase your ram allocation at least 2000+

@Mario191209
Copy link

mine works :/

@Mario191209
Copy link

2023-07-13_17 32 39

@Mario191209
Copy link

are you sure you're using the correct version of zink?

@Mario191209
Copy link

i have no idea

@Kanjiharuto
Copy link

Cần phải có VK_KHR_imageless_framebuffer và timeline semaphore

IMG_20230713_170216
I both have the 2 things you mentioned above, but I don't understand the Zink in my device is just Zink not Vulkan zink

@Mario191209
Copy link

It will change if you switched your language

@Mario191209
Copy link

it still Vulkan Zink but when you switched your language device, the zink name with changed as well

@Mario191209
Copy link

it doesn't effect to zink though it still Vulkan Zink

@Kanjiharuto
Copy link

nó không ảnh hưởng đến zink mặc dù nó vẫn còn Vulkan Zink

I saw it, thanks for that

@arisha12345
Copy link

Nice ! finally zink is back My device is on android 12 It has Mali gpu I can test zink

@rhjdvsgsgks
Copy link
Contributor

could you please cherry pick this commit? so that KHR_timeline_semaphore is not required
alexvorxx/Zink-Mesa-Xlib@23c9c9b

@rhjdvsgsgks
Copy link
Contributor

there is another patch about remove VK_KHR_imageless_framebuffer dependency
termux/termux-packages#10103 (comment)

@zsboylol9900
Copy link

-_-

BuildTools added 2 commits July 31, 2023 20:43
Also adds an override so you can turn it off when you have your own, good-working system Vulkan driver
@SolDev69
Copy link
Contributor

SolDev69 commented Aug 1, 2023

Guessing the merge is when x86-64, arm32, and x86 support

@rhjdvsgsgks
Copy link
Contributor

@thejudge156 if you dont want add those 2 patches. could you please provide the configuration that used to compile mesa? so that i can compile by myself

@Rishidharang
Copy link

How to download I sign in

@artdeell artdeell merged commit 4cd3ab0 into PojavLauncherTeam:v3_openjdk Sep 13, 2023
Copy link

@Gabriejss Gabriejss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O zink era para da mais fps nais sherder aí o zink tira os fps consertar isso pojav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.