Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types declaration #51

Closed
wants to merge 3 commits into from
Closed

Types declaration #51

wants to merge 3 commits into from

Conversation

climaxmba
Copy link
Contributor

@climaxmba climaxmba commented Feb 8, 2024

Add types declaration, Issue: #26

I added a declaration file that describes the Pokedex class and its methods. It will enable type annotations and autocomplete suggestions for both TypeScript and JavaScript developers. Here's how it looks:

image

// Note: Pokedex is destructured on import
import { Pokedex } from "pokeapi-js-wrapper";

@climaxmba climaxmba marked this pull request as ready for review February 8, 2024 09:36
@Naramsim
Copy link
Member

Nice typo-squatting. You are trying to import https://www.npmjs.com/package/typescipt which probably contains malicious code. I reported the package over at NPM as well.

@Naramsim Naramsim closed this Feb 12, 2024
@PokeAPI PokeAPI locked as spam and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants