-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added legends arceus pokeballs #1118
Conversation
lati111
commented
Aug 5, 2024
- Created item category hisuian-balls for the legends arceus pokeballs
- Added all the hisuian pokeball versions. Used identifier naming scheme from PKHeX (la prefix for identifiers) since no naming scheme exists for them currently
- Added flavor text for hisuian pokeball versions copied from bulbapedia
- Hisuian pokeball sprites token from pokesprite as usual (I believe these were added correctly, but I haven't added sprites before so I may have made a mistake)
Definitely mucked something up here, probably something with the sprites. Guess I'll have to do some more research on how it actually works instead of just trying a quick addition I was hoping it would be |
@lati111 Take your time - its a big and complicated project now 😄 you got this! |
Indeed. It doesn't help that I can't find much internal documentation on the hows haha |
Hi, I'm not sure we need to add a whole new category to the data. Isn't it best to add just the new item and use the same category as the standard pokeball? items.csv
Something like the above? |
That definitely works as well. I assumed a new category would be requires as there are seperate categories for standard, special and apricorn balls already. I can definitely move it into that though. |
Let's go with that. To me, these Pokeballs are basically the same as standard ones or special ones. They are restricted only to Pokemon Legends Arceus according to Bulbapedia. |
Thanks @lati111 |
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |