Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legends pokemon arceus pokemon moves scrapped from serebii.net #1149

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

programgames
Copy link
Contributor

Original PR #1132

@Naramsim
Copy link
Member

You need to run black ., there's a file that needs formatting

@programgames
Copy link
Contributor Author

Yeah, I know , but black doesn't format anything :

All done! ✨ 🍰 ✨
37 files left unchanged

Maybe it is because i run it on Windows .

@Naramsim
Copy link
Member

Ah, on my side I have changes. I think that maybe it's the version you are using

@Naramsim
Copy link
Member

If I recall well you should remove a newline in the migrations file.

@programgames
Copy link
Contributor Author

Ok thank you, that was the black version I used, before using the version specified in test-requirements.txt i tested on docker/linux, windows, nothing changed :)

@Naramsim Naramsim merged commit fbb24bf into PokeAPI:master Oct 17, 2024
4 checks passed
@Naramsim
Copy link
Member

Nice! Finally it got merged! Thanks a lot for the efforts!

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants