Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README with Table Of Contents #1155

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

27Jashshah
Copy link
Contributor

Added a Table of Contents, with clickable links to the sections, to the README file.

Copy link
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool suggestion. Did you generate this with an auto-generator or do it yourself? Usually an autogenerated list wouldn't create the <a> tags because Github's markdown parser turns headings into links automatically.

@Naramsim
Copy link
Member

Naramsim commented Oct 28, 2024

Doctoc is one of the generators I used in the past.

I don't know if we need a toc

Definitely the 'a' tags aren't needed

@27Jashshah
Copy link
Contributor Author

So basically I was trying to add a toc with clickable links however it was not working for the top 5 sections for some reason, which is why I added the 'a' tags.

@phalt
Copy link
Member

phalt commented Oct 29, 2024

@27Jashshah what you can do is go to this readme on github.com, click each heading to see the correct link, like this one:

https://github.com/PokeAPI/pokeapi?tab=readme-ov-file#database-setup

the anchor you want is the part after the #

@raghav2005
Copy link

raghav2005 commented Oct 31, 2024

I definitely think that having a ToC makes the README a lot easier to navigate (and to see what's ahead in the README without having to explicitly scroll down), but yeah, there's no need to include the tags cuz I'm pretty sure GitHub automatically handles jumping in Markdowns. I'd be down to fix this myself but not sure how or even if I can edit a PR without being a maintainer.

@27Jashshah
Copy link
Contributor Author

Ok, so the thing is, with the no-breaking spaces ( ), GitHub and Markdown files don't read the headers as they normally would (at least, to my knowledge), so the tags are required for these ones. I have updated the code so that only the headers with the no-breaking space have the tags - I'm just about to commit this change.

Copy link
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thank you for the contribution!

@phalt phalt merged commit b579978 into PokeAPI:master Oct 31, 2024
4 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants