Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect min_turns and max_turns for moves like Wrap and Infestation #1167

Merged

Conversation

thehecktour
Copy link

@thehecktour thehecktour commented Nov 21, 2024

This PR addresses the issue where the min_turns and max_turns values for moves such as Wrap and Infestation were incorrectly in the PokéAPI data. Based on the accurate information from Bulbapedia, I made the fix.

This PR solves the problem addressed in this issue.

Changes Made

Verified Data Sources:

Consulted Bulbapedia for accurate move descriptions:

Infestation (move) - Bulbapedia
Thrash (move) - Bulbapedia

@Naramsim Naramsim merged commit ac05b6e into PokeAPI:master Nov 21, 2024
2 checks passed
@Naramsim
Copy link
Member

Thanks so much! Very well detailed PR!

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants