db flex tape #8627
Merged
db flex tape #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these do happen further on as well but it's pointless to go through the extra steps if we have no intention of using a database anyway, and these procs are called in a bunch of places blindly.
Spookerton
added
Bugfix
|
For what it's worth, this is a bandaid if it works. Properly redoing mysql/maria handling, squashing the two db's together, and having a subsystem specific to connection maintenance and query handling is more appropriate - but that would mean coordinating live data changes as well as writing it |
Spookerton
force-pushed
the
spkrtn/sys/db-things
branch
from
72745c0
to
c0f8a74
Compare
Draft
Atermonera
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A. removes unused forum sql configuration
B. adds some up-front config guards to save a little work on spamming db connect attempts even when sql is disabled
C. Adds SSmisc_slow, a 5 minute wait SS.
The only behavior of SSmisc_slow at the moment is DoReconnects, which handles connection maintenance for dbcon and dbcon_old by:
With logging at every step.
This should remove the need for someone to push the fix database connection button by simply not allowing valid connections to time out when the lobby's been sitting empty for a half day stretch.
Draft because I want to make sure of DoReconnects locally first.