Add job to auto-publish to PyPI in workflows #1508
Conversation
|
Hey @anth-volk could you review this, reopened pr #1496 |
|
Thanks so much, @lordgrim18, will review today. |
There was a problem hiding this comment.
Thanks for this, @lordgrim18, GitHub Actions maintenance is something that has been lacking on this repo. I had a few questions, suggestions, and comments, and look forward to your responses! Thanks again.
| - name: Install package | ||
| run: make install | ||
| - name: Build package | ||
| run: make |
There was a problem hiding this comment.
Out of curiosity, I ran this locally (just make), and this also runs make install, not any build action. Out of curiosity, were you shooting for a different make script? Or alternatively, is this deprecated/a mistake/a different package that is necessary for this to work?
| - name: Publish a Python distribution to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ |
There was a problem hiding this comment.
I don't see this defined anywhere else in the code. Is it possible that this is meant as a stand-in for a different value?
| - name: Checkout repo | ||
| uses: actions/checkout@v3 | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v4 |
There was a problem hiding this comment.
We use actions/setup-python@v5 elsewhere in this script. If this must be v4, could you comment that in here somewhere? Otherwise, could you fix at v5?
| with: | ||
| python-version: 3.9 | ||
| - name: Publish a git tag | ||
| run: ".github/publish-git-tag.sh || true" |
There was a problem hiding this comment.
Out of curiosity, just because I'm new to this, what's the purpose of this line?
Fixes #284 .
What's changed
This PR introduces a new job to the GitHub workflow for automated publishing to PyPI.
Changes Made
.github/workflows/push.ymlfile.Requires
PyPI token in secrets as
PYPI