Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1944 Add test that database is not local #2023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MARRSOX
Copy link

@MARRSOX MARRSOX commented Nov 26, 2024

changes in dockerfile and changes in data.py

I changed the logic when selecting databases and streamlined the ENVironment variables

@anth-volk
Copy link
Collaborator

Hi @MARRSOX, thanks so much for your contribution! A few things, as this is your first contribution:

  1. If running off of a fork, our CI/CD tests will fail due to GitHub permissions issues. Could you instead clone the repo and open off of a branch, as explained in our README? This will require adding you as a contributor, so please respond here if you'd like to go forward.
  2. Please add "Fixes Add test that database is not local #1944" in the description of the PR when you open it, not the title

@MARRSOX
Copy link
Author

MARRSOX commented Nov 26, 2024

I'm going to try to fix it... @anth-volk do you have discord or something? I need to ask something

@MARRSOX MARRSOX closed this Nov 26, 2024
@MARRSOX MARRSOX reopened this Nov 26, 2024
@anth-volk
Copy link
Collaborator

I don't have Discord, unfortunately. I'd be happy to send you our Slack link, either to a GitHub account or an email address, or perhaps via another app.

@MARRSOX
Copy link
Author

MARRSOX commented Nov 26, 2024

I don't have Discord, unfortunately. I'd be happy to send you our Slack link, either to a GitHub account or an email address, or perhaps via another app.

yes I will be grateful, [email protected]

@anth-volk
Copy link
Collaborator

Sent you an email last night. Please feel free to let me know if you have any issues receiving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants