-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml #267
base: master
Are you sure you want to change the base?
Add pyproject.toml #267
Conversation
My understanding was that we could replace setup.py entirely |
I saw in the python documentations that setup.py could be kept, but I believe that getting rid of setup.py makes more sense. I would discuss with Anthony tomorrow about this and make changes if necessary. |
Met with @SylviaDu99 today and am in agreement that |
targeting to fix: issue PolicyEngine#256
…riting with pyproject.toml target to fix: issue PolicyEngine#256
…riting with pyproject.toml target to fix: issue PolicyEngine#256
…riting with pyproject.toml target to fix: issue PolicyEngine#256
…riting with pyproject.toml target to fix: issue PolicyEngine#256
…writing with pyproject.toml target to fix: issue PolicyEngine#256
…for pyproject.toml; add fetch_version.py and __version__.py target to fix: issue PolicyEngine#256
41c44f6
to
592d5dd
Compare
Resolved |
build: add tomli dependency to pyproject.toml target to fix: issue PolicyEngine#256
target to fix: issue PolicyEngine#256
target to fix: issue PolicyEngine#256
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 79.73% 79.74%
=======================================
Files 192 193 +1
Lines 10057 10081 +24
Branches 1311 1315 +4
=======================================
+ Hits 8019 8039 +20
- Misses 1753 1756 +3
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this @SylviaDu99.
Unfortunately, if you check the actions, even though they say they pass, the check_version_number
action actually fails. Additionally, we've been facing challenges getting versioning to actually work with pyproject.toml
(see this issue in the -us-data
repository). This is obviously something we'll need to get working. That said, I don't think there's value to each working separately to get a versioning script working.
I think there are two ways we can proceed:
- You dig deeper into getting this versioning script working: happy to hand it over to you
- We allow this PR to sit and we choose something that would be more impactful and leave the switch to
pyproject.toml
alone for the time being
I'd lean more toward the second, as we're already facing pyproject.toml
configuration-related issues on -us-data
. Curious to hear your thoughts.
I'd also favor putting things that aren't broken on hold for the moment until we stabilize the rest of the codebase. Really appreciate this work so far as it'll be a great way to modernize soon. |
Thank you for your comments. I would also agree to move onto things that are more impactful. |
Thanks guys- converting to draft since not immediately mergeable. |
9fda425
to
9fbe198
Compare
WIP: add pyproject.toml, test_toml.py; edited setup.py to avoid overwriting with pyproject.toml
target to fix: issue #256