updated logic for files separately - special cases #155
Conversation
noman404
changed the title
state_itemized_deductions state_taxable_income state_income_tax_before_non_refundable_credits added special case for states which failed
|
Al - could you resolve outstanding conversations if ready for review? |
| - ms: | ||
| implemented: false | ||
| variable: na_pe | ||
| - de: |
There was a problem hiding this comment.
we need:
de_income_tax_before_non_refundable_credits_indv
de_income_tax_before_non_refundable_credits_joint
ms_income_tax_before_credits_indiv
ms_income_tax_before_credits_joint
| special_cases: | ||
| - ms: | ||
| implemented: false | ||
| variable: na_pe |
There was a problem hiding this comment.
Why would we have special case code here?
There was a problem hiding this comment.
it gives exception when call ms_eitc variable
| - tx: | ||
| implemented: false | ||
| variable: na_pe |
There was a problem hiding this comment.
| - tx: | |
| implemented: false | |
| variable: na_pe |
Texas does not have state income tax
There was a problem hiding this comment.
right, so the implementation need to avoid extra variable call. This how if this states exists, the code will not execute for those states.
There was a problem hiding this comment.
Can you elaborate? Do we need to this for every state without income tax?
| variables: | ||
| - ms_itemized_deductions_indiv | ||
| - ms_itemized_deductions_joint | ||
| - ar: |
There was a problem hiding this comment.
we need:
de_itemized_deductions_indv
de_itemized_deductions_joint
| implemented: true | ||
| pre_variable: de_files_separately | ||
| variables: | ||
| - de_standard_deduction_indiv |
There was a problem hiding this comment.
| - de_standard_deduction_indiv | |
| - de_standard_deduction_indv |
| special_cases: | ||
| - ms: | ||
| implemented: false | ||
| variable: na_pe |
There was a problem hiding this comment.
same question as above
There was a problem hiding this comment.
v40: state total credits. Need multiple variable ms_non_refundable_credit + ms_refundable_credits, ms_non_refundable_credit does not exists, for this case, do we also need to use ms_files_separately? i did not see any ms_non_refundable_credit_indiv/indv though
There was a problem hiding this comment.
the variable name is ms_non_refundable_credits - this does not depend on the filing separately structure
In general all of the Mississippi state related variables are in the variables/gov/states/ms folder
The same goes for the other states
| variables: | ||
| - ky_taxable_income_indiv | ||
| - ky_taxable_income_joint | ||
| special_cases: |
There was a problem hiding this comment.
de_taxable_income_indv
de_taxable_income_joint
| @@ -488,6 +611,12 @@ policyengine_to_taxsim: | |||
| - mn: | |||
There was a problem hiding this comment.
Separate question but is the full group text here not accurate?
full_text_group: "State Tax Calculation" - this is property tax credit right?
updated logic for 'submission/files separately' special cases for
Mississippi
Arkansas
Montana
Delaware
Iowa
Kentucky
Fixes #131