Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI validation fixes #914

Merged
merged 7 commits into from
Aug 8, 2024
Merged

SPI validation fixes #914

merged 7 commits into from
Aug 8, 2024

Conversation

anth-volk
Copy link
Collaborator

@anth-volk anth-volk commented Jul 29, 2024

Fixes #918.
Fixes #919.

This PR raises the PolicyEngine UK model's convergence with the SPI's 2020/21 data. This PR also introduces a documentation page (currently a draft requiring some clarification) that describes the validation exercise, as well as areas where the two models diverge.

@anth-volk
Copy link
Collaborator Author

Absolute error measurement as of commit c2039ef:

<=10      91.461733
<1000      5.525746
>=1000     1.865212
<100       1.147309

@anth-volk
Copy link
Collaborator Author

Absolute error measurement as of commit 581569b:

<=10      92.685731
<1000      4.806584
>=1000     1.671160
<100       0.836525

@anth-volk
Copy link
Collaborator Author

Absolute error measurement as of ee35212:

<=10      92.695427
<1000      4.807466
>=1000     1.670153
<100       0.826954

@anth-volk
Copy link
Collaborator Author

Absolute error as of c974b42:

<=10      92.685731
<1000      4.806584
>=1000     1.671160
<100       0.836525

@anth-volk anth-volk marked this pull request as ready for review August 7, 2024 21:57
@nikhilwoodruff nikhilwoodruff merged commit 8b7cbcd into master Aug 8, 2024
3 checks passed
@nikhilwoodruff nikhilwoodruff deleted the fix/spi-fixes branch August 8, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation page on SPI validation Fix Scottish rates for 2020/21
2 participants