Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

South Carolina Use Tax #4545

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

South Carolina Use Tax #4545

wants to merge 32 commits into from
+325 −3

Conversation

keepjojoyoung
Copy link
Contributor

Fixes #4514

PavelMakarchuk
PavelMakarchuk requested changes May 30, 2024
View reviewed changes
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/main_rate.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/main_rate.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/main_rate.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/group_3_rate.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/county_group_3.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/county_group_3.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/county_group_3.yaml Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/is_group_1_county.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/is_group_1_county.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/is_group_1_county.py Outdated Show resolved Hide resolved
PavelMakarchuk
PavelMakarchuk requested changes Jun 6, 2024
View reviewed changes
...variables/gov/states/sc/tax/income/subtractions/sc_use_tax/sc_use_tax_in_group_one_county.py Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/use_tax/county_group/one.yaml Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/sc_use_tax.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/sc_use_tax.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/sc/tax/income/subtractions/sc_use_tax/sc_use_tax.py Outdated Show resolved Hide resolved
...variables/gov/states/sc/tax/income/subtractions/sc_use_tax/sc_use_tax_in_group_one_county.py Outdated Show resolved Hide resolved
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review August 6, 2024 00:08
@MaxGhenis
Copy link
Contributor

Lint and test failures

@PavelMakarchuk PavelMakarchuk removed the request for review from MaxGhenis August 6, 2024 15:39
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (daf7988) to head (6a5fe4c).
Report is 74 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
+ Coverage   98.98%   99.00%   +0.01%     
==========================================
  Files        2517     2533      +16     
  Lines       36615    36833     +218     
  Branches      197      196       -1     
==========================================
+ Hits        36245    36467     +222     
+ Misses        339      337       -2     
+ Partials       31       29       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaxGhenis
MaxGhenis requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we instead map counties to county groups, then have a breakdown parameter for the % for each county group? similar to state_group

policyengine_us/parameters/gov/states/sc/tax/income/use_tax/group_one.yaml
@@ -0,0 +1,11 @@
description: South Carolina levies a local use tax of group 1 counties at this percent of out of state purchase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and others

Suggested change
description: South Carolina levies a local use tax of group 1 counties at this percent of out of state purchase.
description: South Carolina levies a local use tax of group 1 counties at this percent of out of state purchases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis requested changes

@PavelMakarchuk PavelMakarchuk PavelMakarchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

South Carolina Use Tax
3 participants
@keepjojoyoung @MaxGhenis @PavelMakarchuk