-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Colorado CDCCs beginning in 2026 #4656
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4656 +/- ##
==========================================
+ Coverage 98.97% 99.00% +0.03%
==========================================
Files 2467 2461 -6
Lines 35869 35815 -54
Branches 184 184
==========================================
- Hits 35500 35458 -42
+ Misses 339 327 -12
Partials 30 30 ☔ View full report in Codecov by Sentry. |
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjustment_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjustment_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
I think this summary states that two credits are combined into one -> we will need variable adjustments as well I believe |
We currently have 2 vairbales: After 2026 this should be just the co_cdcc so we will set the other variable to 0 starting in 2026 (through an |
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjusted_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/co/tax/income/credits/cdcc/co_low_income_cdcc.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjusted_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Show resolved
Hide resolved
policyengine_us/variables/gov/states/co/tax/income/credits/cdcc/co_low_income_cdcc.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/estimated_adjusted_factor.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/unified.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
@@ -13,4 +13,5 @@ class co_eitc(Variable): | |||
def formula(tax_unit, period, parameters): | |||
federal_eitc = tax_unit("eitc", period) | |||
p = parameters(period).gov.states.co.tax.income.credits | |||
return federal_eitc * p.eitc.match | |||
estimated_adjusted_factor = p.eitc.estimated_adjusted_factor | |||
return federal_eitc * p.eitc.match.calc(estimated_adjusted_factor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt the factor just a value? We would just need a multiplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need to match the correct percentage according to the factor? so I use the .cal() here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad I meant, why do we make the match percentage dependent on the adjustment factor? Dont we just multiply it by the factor and the match is based on income?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #4637