Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NYS Clean Heat Program for CH&E, NGRID, NYSEG, O&R, RG&E customers #4693

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

NYS Clean Heat Program for CH&E, NGRID, NYSEG, O&R, RG&E customers #4693

wants to merge 19 commits into from
+560 −0

Conversation

mngh037
Copy link
Contributor

@mngh037 mngh037 commented Jun 26, 2024 •
edited
Loading

Fixes #4645

@mngh037 mngh037 changed the title Added NYS Clean Heat Program - CH&E, NGRID, NYSEG, O&R, RG&E Added NYS Clean Heat Program for CH&E, NGRID, NYSEG, O&R, RG&E customers Jun 26, 2024
PavelMakarchuk
PavelMakarchuk requested changes Jul 1, 2024
View reviewed changes
policyengine_us/parameters/gov/states/ny/nysdps/clean_heat/cap.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ny/nysdps/clean_heat/cap.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ny/nysdps/clean_heat/contractor_reward.yaml Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ny/nysdps/clean_heat_project_cost.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ny/nysdps/clean_heat_others_incentives.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ny/nysdps/clean_heat_others_incentives.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ny/nysdps/clean_heat_others_incentives.py Outdated Show resolved Hide resolved
...housing/expenditures/energy_efficient_property/geothermal_heat_pump_property_expenditures.py Outdated Show resolved Hide resolved
@mngh037 mngh037 changed the title Added NYS Clean Heat Program for CH&E, NGRID, NYSEG, O&R, RG&E customers NYS Clean Heat Program for CH&E, NGRID, NYSEG, O&R, RG&E customers Jul 2, 2024
@mngh037 mngh037 marked this pull request as ready for review July 29, 2024 15:18
PavelMakarchuk
PavelMakarchuk approved these changes Jul 29, 2024
View reviewed changes
policyengine_us/variables/gov/states/ny/nysdps/ny_clean_heat_utility_provider.py
from policyengine_us.model_api import *


class UtilityProvider(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class UtilityProvider(Enum):
class NyCleanHeatUtilityProvider(Enum):

policyengine_us/variables/gov/states/ny/nysdps/ny_clean_heat_project_cost.py
class ny_clean_heat_project_cost(Variable):
value_type = float
entity = Household
label = "Qualified heat pump installation project cost"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "Qualified heat pump installation project cost"
label = "Qualified heat pump installation project cost for the new york clean heat program"

policyengine_us/variables/gov/states/ny/nysdps/ny_clean_heat_others_incentives.py
Comment on lines +61 to +67
qualified_incentive = select(
[
category != category.possible_values.C3,
category == category.possible_values.C3,
],
[uncapped_incentive - contractor_reward, gshp_g3_incentive],
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just make this a where statement:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qualified_incentive = select(
[
category != category.possible_values.C3,
category == category.possible_values.C3,
],
[uncapped_incentive - contractor_reward, gshp_g3_incentive],
)
c3_category = category == category.possible_values.C3
reduced_uncapped_incentive = uncapped_incentive - contractor_reward
qualified_incentive = where(c3_category, gshp_g3_incentive, reduced_uncapped_incentive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NYS Clean Heat Program - CH&E, NGRID, NYSEG, O&R, RG&E
3 participants
@mngh037 @PavelMakarchuk @fuyukitn