New York State SUN #4701
Draft
New York State SUN #4701
+238
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
changed the title
PavelMakarchuk
requested changes
Jul 1, 2024
Comment on lines
1
to
4
| from ... policyengine_us.model_api import * | ||
| from ... policyengine_us.entities import * | ||
| from ... policyengine_us.tools.general import * | ||
| from ... kj_alison_issues.files import * # do we need this one??? #wont hurt? |
There was a problem hiding this comment.
Suggested change
| from ... policyengine_us.model_api import * | |
| from ... policyengine_us.entities import * | |
| from ... policyengine_us.tools.general import * | |
| from ... kj_alison_issues.files import * # do we need this one??? #wont hurt? | |
| from policyengine_us.model_api import * |
There was a problem hiding this comment.
delete duplicate files and move everything out of the this folder
There was a problem hiding this comment.
I am not sure if this variable belongs to this PR
There was a problem hiding this comment.
format everything to relate to NY and add referencing to display the origins of the inputs
…othermal_energy_system/cap.yaml
…othermal_energy_system/rate.yaml
…/credits/ny_geothermal_energy_systems_credit.yaml
…geothermal_energy_system_credit.py
…es/qualified_geothermal_energy_system_expenditures.py
PavelMakarchuk
changed the title
PavelMakarchuk
requested changes
Jul 1, 2024
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
| label = "Past year or projected year home energy use in annual kilowatt hours" | ||
| unit = "kWh/year" | ||
| definition_period = YEAR | ||
| reference = "" |
There was a problem hiding this comment.
add a ref here. (manual)
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/residential_solar_system_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/residential_solar_system_use.py
Outdated
Show resolved
Hide resolved
…se.py Co-authored-by: Pavel Makarchuk <[email protected]>
Co-authored-by: Pavel Makarchuk <[email protected]>
PavelMakarchuk
requested changes
Jul 3, 2024
| 2010-06-07: 0.4 | ||
|
|
||
| CON_ED: | ||
| 0000-01-01: .inf |
There was a problem hiding this comment.
Suggested change
| 0000-01-01: .inf |
| 2010-06-07: 0.8 | ||
|
|
||
| UPSTATE: | ||
| 0000-01-01: .inf |
There was a problem hiding this comment.
Suggested change
| 0000-01-01: .inf |
|
|
||
|
|
||
| LONG_ISLAND: | ||
| 0000-01-01: .inf |
There was a problem hiding this comment.
Suggested change
| 0000-01-01: .inf |
| period: year | ||
| label: New York max size PV system multiplier | ||
| reference: | ||
| - title: NY-Sun Residential & Nonresidential Incentive Program #add detail after |
There was a problem hiding this comment.
Suggested change
| - title: NY-Sun Residential & Nonresidential Incentive Program #add detail after | |
| - title: NY-Sun Residential & Nonresidential Incentive Program # Page 4 |
| @@ -0,0 +1,16 @@ | |||
| description: NY SUN maximum size PV system size multiplier (does not exceed 110%) | |||
There was a problem hiding this comment.
Suggested change
| description: NY SUN maximum size PV system size multiplier (does not exceed 110%) | |
| description: New York caps the PV system size at the following percentage of projected energy use under the SUN incentive program. |
Comment on lines
+24
to
+25
| multiplier = p.max_pv_system_size | ||
| max_kwh = ny_sun_current_solar_energy_use * multiplier |
There was a problem hiding this comment.
Suggested change
| multiplier = p.max_pv_system_size | |
| max_kwh = ny_sun_current_solar_energy_use * multiplier | |
| max_kwh = ny_sun_current_solar_energy_use * p.max_pv_system_size |
| max_kwh = ny_sun_current_solar_energy_use * multiplier | ||
| #Conversion factor of 1 kW=1 kWh / 3600 (for number of seconds in an hr) | ||
| max_kw = max_kwh / 3600 | ||
| approved_kw = min(max_kw, ny_sun_new_pw_system_size) |
There was a problem hiding this comment.
Suggested change
| approved_kw = min(max_kw, ny_sun_new_pw_system_size) | |
| capped_kw = min_(max_kw, ny_sun_new_pw_system_size) |
| @@ -0,0 +1,25 @@ | |||
| description: NY gives regional incentives for residential solar projects based on solar system size | |||
There was a problem hiding this comment.
Suggested change
| description: NY gives regional incentives for residential solar projects based on solar system size | |
| description: New York provides the following percentage of the past or projected solar energy usage under the SUN incentive program, based on region. |
| period: year | ||
| breakdown: | ||
| - ny_sun_region_status | ||
| label: New York regional incentive on residential solar projects |
There was a problem hiding this comment.
Suggested change
| label: New York regional incentive on residential solar projects | |
| label: New York SUN incentive rate |
There was a problem hiding this comment.
rename to rate.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft fixes for issue#4646