-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New York State SUN #4701
base: master
Are you sure you want to change the base?
New York State SUN #4701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally confused about the purpose of this PR,
from ... policyengine_us.model_api import * | ||
from ... policyengine_us.entities import * | ||
from ... policyengine_us.tools.general import * | ||
from ... kj_alison_issues.files import * # do we need this one??? #wont hurt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from ... policyengine_us.model_api import * | |
from ... policyengine_us.entities import * | |
from ... policyengine_us.tools.general import * | |
from ... kj_alison_issues.files import * # do we need this one??? #wont hurt? | |
from policyengine_us.model_api import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete duplicate files and move everything out of the this folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this variable belongs to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format everything to relate to NY and add referencing to display the origins of the inputs
…othermal_energy_system/cap.yaml
…othermal_energy_system/rate.yaml
…/credits/ny_geothermal_energy_systems_credit.yaml
…geothermal_energy_system_credit.py
…es/qualified_geothermal_energy_system_expenditures.py
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
label = "Past year or projected year home energy use in annual kilowatt hours" | ||
unit = "kWh/year" | ||
definition_period = YEAR | ||
reference = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a ref here. (manual)
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/current_solar_energy_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/residential_solar_system_use.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ny/residential_solar_system_use.py
Outdated
Show resolved
Hide resolved
…se.py Co-authored-by: Pavel Makarchuk <[email protected]>
Co-authored-by: Pavel Makarchuk <[email protected]>
2010-06-07: 0.4 | ||
|
||
CON_ED: | ||
0000-01-01: .inf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0000-01-01: .inf |
2010-06-07: 0.8 | ||
|
||
UPSTATE: | ||
0000-01-01: .inf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0000-01-01: .inf |
|
||
|
||
LONG_ISLAND: | ||
0000-01-01: .inf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0000-01-01: .inf |
period: year | ||
label: New York max size PV system multiplier | ||
reference: | ||
- title: NY-Sun Residential & Nonresidential Incentive Program #add detail after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- title: NY-Sun Residential & Nonresidential Incentive Program #add detail after | |
- title: NY-Sun Residential & Nonresidential Incentive Program # Page 4 |
@@ -0,0 +1,16 @@ | |||
description: NY SUN maximum size PV system size multiplier (does not exceed 110%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: NY SUN maximum size PV system size multiplier (does not exceed 110%) | |
description: New York caps the PV system size at the following percentage of projected energy use under the SUN incentive program. |
multiplier = p.max_pv_system_size | ||
max_kwh = ny_sun_current_solar_energy_use * multiplier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiplier = p.max_pv_system_size | |
max_kwh = ny_sun_current_solar_energy_use * multiplier | |
max_kwh = ny_sun_current_solar_energy_use * p.max_pv_system_size |
max_kwh = ny_sun_current_solar_energy_use * multiplier | ||
#Conversion factor of 1 kW=1 kWh / 3600 (for number of seconds in an hr) | ||
max_kw = max_kwh / 3600 | ||
approved_kw = min(max_kw, ny_sun_new_pw_system_size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved_kw = min(max_kw, ny_sun_new_pw_system_size) | |
capped_kw = min_(max_kw, ny_sun_new_pw_system_size) |
@@ -0,0 +1,25 @@ | |||
description: NY gives regional incentives for residential solar projects based on solar system size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: NY gives regional incentives for residential solar projects based on solar system size | |
description: New York provides the following percentage of the past or projected solar energy usage under the SUN incentive program, based on region. |
period: year | ||
breakdown: | ||
- ny_sun_region_status | ||
label: New York regional incentive on residential solar projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label: New York regional incentive on residential solar projects | |
label: New York SUN incentive rate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to rate.yaml
Draft fixes for issue#4646