Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New York supplemental tax incremental benefit repeal for 2028 #4745

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

YichunRen
Copy link
Contributor

Fixes #4728

@YichunRen YichunRen changed the title YichunRen/issue4728 New York supplemental tax incremental benefit repeal for 2028 Jul 16, 2024
@YichunRen YichunRen marked this pull request as ready for review August 8, 2024 05:57
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (daf7988) to head (97552e0).
Report is 162 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4745      +/-   ##
==========================================
+ Coverage   98.98%   99.00%   +0.01%     
==========================================
  Files        2517     2536      +19     
  Lines       36615    36847     +232     
  Branches      197      153      -44     
==========================================
+ Hits        36245    36481     +236     
+ Misses        339      337       -2     
+ Partials       31       29       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to break up the long formula in the future but looks good for now

@MaxGhenis MaxGhenis merged commit 2d8db20 into PolicyEngine:master Aug 29, 2024
5 of 6 checks passed
@PavelMakarchuk
Copy link
Collaborator

PavelMakarchuk commented Aug 29, 2024

Would be good to break up the long formula in the future but looks good for now

Will file an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New York supplemental tax incremental benefit repeal for 2028
3 participants